[PATCH v2 5/6] drm/crtc: add sanity checks to create_dumb()

2014-02-05 Thread David Herrmann
ping On Thu, Jan 23, 2014 at 3:10 PM, David Herrmann wrote: > Hi > > On Thu, Jan 23, 2014 at 2:55 PM, Ville Syrj?l? > wrote: >> On Thu, Jan 23, 2014 at 01:53:15PM +0100, David Herrmann wrote: >>> Lets make sure some basic expressions are always true: >>> bpp != NULL >>> width != NULL >>>

[PATCH v2 5/6] drm/crtc: add sanity checks to create_dumb()

2014-01-23 Thread Ville Syrjälä
On Thu, Jan 23, 2014 at 01:53:15PM +0100, David Herrmann wrote: > Lets make sure some basic expressions are always true: > bpp != NULL > width != NULL > height != NULL > stride = bpp * width < 2^32 > size = stride * height < 2^32 > PAGE_ALIGN(size) < 2^32 > > At least the udl driver do

[PATCH v2 5/6] drm/crtc: add sanity checks to create_dumb()

2014-01-23 Thread David Herrmann
Hi On Thu, Jan 23, 2014 at 2:55 PM, Ville Syrj?l? wrote: > On Thu, Jan 23, 2014 at 01:53:15PM +0100, David Herrmann wrote: >> Lets make sure some basic expressions are always true: >> bpp != NULL >> width != NULL >> height != NULL >> stride = bpp * width < 2^32 >> size = stride * height

[PATCH v2 5/6] drm/crtc: add sanity checks to create_dumb()

2014-01-23 Thread David Herrmann
Lets make sure some basic expressions are always true: bpp != NULL width != NULL height != NULL stride = bpp * width < 2^32 size = stride * height < 2^32 PAGE_ALIGN(size) < 2^32 At least the udl driver doesn't check for multiplication-overflows, so lets just make sure it will never hap