Re: [PATCH v2 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-22 Thread Kieran Bingham
Hi Laurent, On 22/05/17 13:24, Laurent Pinchart wrote: > Hi Kieran, > > On Monday 22 May 2017 13:16:11 Kieran Bingham wrote: >> On 17/05/17 00:20, Laurent Pinchart wrote: >>> For planes handled by a VSP instance, map the framebuffer memory through >>> the VSP to ensure proper IOMMU handling. >>>

Re: [PATCH v2 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-22 Thread Kieran Bingham
Hi Laurent, Thankyou for the patch. On 17/05/17 00:20, Laurent Pinchart wrote: > For planes handled by a VSP instance, map the framebuffer memory through > the VSP to ensure proper IOMMU handling. > > Signed-off-by: Laurent Pinchart Looks good except for a small unsigned int comparison causing

Re: [PATCH v2 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-22 Thread Kieran Bingham
On 22/05/17 14:23, Laurent Pinchart wrote: > Hello Geert and Kieran, > > On Monday 22 May 2017 15:00:27 Geert Uytterhoeven wrote: >> On Mon, May 22, 2017 at 2:52 PM, Kieran Bingham wrote: >>> My only distaste there is having to then add the [i-1] index to the >>> sg_tables. >>> >>> I have just exp

Re: [PATCH v2 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-22 Thread Kieran Bingham
Hi Laurent, Thankyou for the patch. On 17/05/17 00:20, Laurent Pinchart wrote: > For planes handled by a VSP instance, map the framebuffer memory through > the VSP to ensure proper IOMMU handling. > > Signed-off-by: Laurent Pinchart Looks good except for a small unsigned int comparison causing

Re: [PATCH v2 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-22 Thread Laurent Pinchart
Hello Geert and Kieran, On Monday 22 May 2017 15:00:27 Geert Uytterhoeven wrote: > On Mon, May 22, 2017 at 2:52 PM, Kieran Bingham wrote: > > My only distaste there is having to then add the [i-1] index to the > > sg_tables. > > > > I have just experimented with: > > > > fail: > > for (;

Re: [PATCH v2 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-22 Thread Geert Uytterhoeven
On Mon, May 22, 2017 at 2:52 PM, Kieran Bingham wrote: > My only distaste there is having to then add the [i-1] index to the sg_tables. > > I have just experimented with: > > fail: > for (; i-- != 0;) { > struct sg_table *sgt = &rstate->sg_tables[i]; > ... >

Re: [PATCH v2 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-22 Thread Laurent Pinchart
Hi Kieran, On Monday 22 May 2017 13:16:11 Kieran Bingham wrote: > On 17/05/17 00:20, Laurent Pinchart wrote: > > For planes handled by a VSP instance, map the framebuffer memory through > > the VSP to ensure proper IOMMU handling. > > > > Signed-off-by: Laurent Pinchart > > > > Looks good excep

[PATCH v2 5/5] drm: rcar-du: Map memory through the VSP device

2017-05-16 Thread Laurent Pinchart
For planes handled by a VSP instance, map the framebuffer memory through the VSP to ensure proper IOMMU handling. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 74 --- drivers/gpu/drm/rcar-du/rcar_du_vsp.h | 2 + 2 files changed, 70