[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-02-15 Thread Mario Kleiner
On 02/11/2013 10:00 AM, Thierry Reding wrote: > On Tue, Jan 22, 2013 at 06:27:24PM +0100, Mario Kleiner wrote: >> On 22.01.13 09:31, Terje Bergstr?m wrote: >>> On 14.01.2013 18:06, Thierry Reding wrote: +static int tegra_dc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb, >>>

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-02-15 Thread Mario Kleiner
On 02/11/2013 10:00 AM, Thierry Reding wrote: On Tue, Jan 22, 2013 at 06:27:24PM +0100, Mario Kleiner wrote: On 22.01.13 09:31, Terje Bergström wrote: On 14.01.2013 18:06, Thierry Reding wrote: +static int tegra_dc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb, +

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-02-11 Thread Thierry Reding
On Tue, Jan 22, 2013 at 06:27:24PM +0100, Mario Kleiner wrote: > On 22.01.13 09:31, Terje Bergstr?m wrote: > >On 14.01.2013 18:06, Thierry Reding wrote: > >>+static int tegra_dc_page_flip(struct drm_crtc *crtc, struct > >>drm_framebuffer *fb, > >>+ struct drm_pending_vblank

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-02-11 Thread Thierry Reding
On Tue, Jan 22, 2013 at 06:27:24PM +0100, Mario Kleiner wrote: > On 22.01.13 09:31, Terje Bergström wrote: > >On 14.01.2013 18:06, Thierry Reding wrote: > >>+static int tegra_dc_page_flip(struct drm_crtc *crtc, struct > >>drm_framebuffer *fb, > >>+ struct drm_pending_vblank

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Mario Kleiner
On 22.01.13 09:31, Terje Bergstr?m wrote: > On 14.01.2013 18:06, Thierry Reding wrote: >> +static int tegra_dc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer >> *fb, >> + struct drm_pending_vblank_event *event) >> +{ >> +struct tegra_framebuffer *newfb = to_te

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Terje Bergström
On 22.01.2013 11:48, Lucas Stach wrote: > I think the test suite is enough to fulfil the formal requirement of > having a working userspace. But still it would be nice to have at least > some simple accel functions working in the DDX. Maybe just to see on how > well the current design integrates in

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Terje Bergström
On 22.01.2013 11:31, Thierry Reding wrote: > I'm not quite sure if I remember correctly, but I think David mentioned > something along the lines of requiring a working userspace that can be > used to test the DRM interfaces as a prerequisite to getting this kind > of code merged. That's why we hav

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Terje Bergström
On 22.01.2013 11:15, Lucas Stach wrote: > But even if I get this out real soon, I'm not really comfortable with > speeding things to 3.9. I would like to review the userspace side of > thing a lot more thoroughly, before committing to the interface. But > maybe this can also happen in the 3.9 RC ti

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Lucas Stach
Am Dienstag, den 22.01.2013, 11:44 +0200 schrieb Terje Bergstr?m: > On 22.01.2013 11:31, Thierry Reding wrote: > > I'm not quite sure if I remember correctly, but I think David mentioned > > something along the lines of requiring a working userspace that can be > > used to test the DRM interfaces a

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Thierry Reding
On Tue, Jan 22, 2013 at 10:15:21AM +0100, Lucas Stach wrote: > Am Dienstag, den 22.01.2013, 09:57 +0100 schrieb Thierry Reding: > > On Tue, Jan 22, 2013 at 10:31:11AM +0200, Terje Bergstr?m wrote: > > > Of course, this has the prerequisite of having support for syncpts, > > > which I hoped we would

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Terje Bergström
On 14.01.2013 18:06, Thierry Reding wrote: > +static int tegra_dc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer > *fb, > + struct drm_pending_vblank_event *event) > +{ > + struct tegra_framebuffer *newfb = to_tegra_fb(fb); > + struct tegra_dc *dc = to_te

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Lucas Stach
Am Dienstag, den 22.01.2013, 09:57 +0100 schrieb Thierry Reding: > On Tue, Jan 22, 2013 at 10:31:11AM +0200, Terje Bergstr?m wrote: > > Of course, this has the prerequisite of having support for syncpts, > > which I hoped we would get to 3.9. The review for host1x patches seem to > > have stalled,

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Thierry Reding
On Tue, Jan 22, 2013 at 10:31:11AM +0200, Terje Bergstr?m wrote: > On 14.01.2013 18:06, Thierry Reding wrote: > > +static int tegra_dc_page_flip(struct drm_crtc *crtc, struct > > drm_framebuffer *fb, > > + struct drm_pending_vblank_event *event) > > +{ > > + struct tegra_

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Mario Kleiner
On 22.01.13 09:31, Terje Bergström wrote: On 14.01.2013 18:06, Thierry Reding wrote: +static int tegra_dc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb, + struct drm_pending_vblank_event *event) +{ + struct tegra_framebuffer *newfb = to_tegra_fb(f

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Terje Bergström
On 22.01.2013 11:48, Lucas Stach wrote: > I think the test suite is enough to fulfil the formal requirement of > having a working userspace. But still it would be nice to have at least > some simple accel functions working in the DDX. Maybe just to see on how > well the current design integrates in

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Lucas Stach
Am Dienstag, den 22.01.2013, 11:44 +0200 schrieb Terje Bergström: > On 22.01.2013 11:31, Thierry Reding wrote: > > I'm not quite sure if I remember correctly, but I think David mentioned > > something along the lines of requiring a working userspace that can be > > used to test the DRM interfaces a

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Terje Bergström
On 22.01.2013 11:31, Thierry Reding wrote: > I'm not quite sure if I remember correctly, but I think David mentioned > something along the lines of requiring a working userspace that can be > used to test the DRM interfaces as a prerequisite to getting this kind > of code merged. That's why we hav

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Thierry Reding
On Tue, Jan 22, 2013 at 10:15:21AM +0100, Lucas Stach wrote: > Am Dienstag, den 22.01.2013, 09:57 +0100 schrieb Thierry Reding: > > On Tue, Jan 22, 2013 at 10:31:11AM +0200, Terje Bergström wrote: > > > Of course, this has the prerequisite of having support for syncpts, > > > which I hoped we would

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Terje Bergström
On 22.01.2013 11:15, Lucas Stach wrote: > But even if I get this out real soon, I'm not really comfortable with > speeding things to 3.9. I would like to review the userspace side of > thing a lot more thoroughly, before committing to the interface. But > maybe this can also happen in the 3.9 RC ti

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Lucas Stach
Am Dienstag, den 22.01.2013, 09:57 +0100 schrieb Thierry Reding: > On Tue, Jan 22, 2013 at 10:31:11AM +0200, Terje Bergström wrote: > > Of course, this has the prerequisite of having support for syncpts, > > which I hoped we would get to 3.9. The review for host1x patches seem to > > have stalled,

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Thierry Reding
On Tue, Jan 22, 2013 at 10:31:11AM +0200, Terje Bergström wrote: > On 14.01.2013 18:06, Thierry Reding wrote: > > +static int tegra_dc_page_flip(struct drm_crtc *crtc, struct > > drm_framebuffer *fb, > > + struct drm_pending_vblank_event *event) > > +{ > > + struct tegra_

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Terje Bergström
On 14.01.2013 18:06, Thierry Reding wrote: > +static int tegra_dc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer > *fb, > + struct drm_pending_vblank_event *event) > +{ > + struct tegra_framebuffer *newfb = to_tegra_fb(fb); > + struct tegra_dc *dc = to_te

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-17 Thread Mark Zhang
On 01/15/2013 12:06 AM, Thierry Reding wrote: > All the necessary support bits like .mode_set_base() and VBLANK are now > available, so page-flipping case easily be implemented on top. > > Signed-off-by: Thierry Reding [...] > + > +static int tegra_dc_page_flip(struct drm_crtc *crtc, struct drm_f

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-17 Thread Mark Zhang
On 01/16/2013 07:53 PM, Lucas Stach wrote: > Am Mittwoch, den 16.01.2013, 19:10 +0800 schrieb Mark Zhang: >> I'm testing the pageflip & vblank change on cardhu. Seems the HDMI >> doesn't work(LVDS only is OK). I'll let you know if I get something. >> > Just to provide another data point: I'm runnin

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Mark Zhang
On 01/15/2013 12:06 AM, Thierry Reding wrote: > All the necessary support bits like .mode_set_base() and VBLANK are now > available, so page-flipping case easily be implemented on top. > > Signed-off-by: Thierry Reding [...] > + > +static int tegra_dc_page_flip(struct drm_crtc *crtc, struct drm_f

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Mark Zhang
On 01/16/2013 07:53 PM, Lucas Stach wrote: > Am Mittwoch, den 16.01.2013, 19:10 +0800 schrieb Mark Zhang: >> I'm testing the pageflip & vblank change on cardhu. Seems the HDMI >> doesn't work(LVDS only is OK). I'll let you know if I get something. >> > Just to provide another data point: I'm runnin

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Mark Zhang
I'm testing the pageflip & vblank change on cardhu. Seems the HDMI doesn't work(LVDS only is OK). I'll let you know if I get something. Mark On 01/15/2013 12:06 AM, Thierry Reding wrote: > All the necessary support bits like .mode_set_base() and VBLANK are now > available, so page-flipping case ea

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Lucas Stach
Am Mittwoch, den 16.01.2013, 19:10 +0800 schrieb Mark Zhang: > I'm testing the pageflip & vblank change on cardhu. Seems the HDMI > doesn't work(LVDS only is OK). I'll let you know if I get something. > Just to provide another data point: I'm running this series and don't see any failures with DVI

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Lucas Stach
Am Mittwoch, den 16.01.2013, 19:10 +0800 schrieb Mark Zhang: > I'm testing the pageflip & vblank change on cardhu. Seems the HDMI > doesn't work(LVDS only is OK). I'll let you know if I get something. > Just to provide another data point: I'm running this series and don't see any failures with DVI

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Mark Zhang
I'm testing the pageflip & vblank change on cardhu. Seems the HDMI doesn't work(LVDS only is OK). I'll let you know if I get something. Mark On 01/15/2013 12:06 AM, Thierry Reding wrote: > All the necessary support bits like .mode_set_base() and VBLANK are now > available, so page-flipping case ea

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-14 Thread Thierry Reding
All the necessary support bits like .mode_set_base() and VBLANK are now available, so page-flipping case easily be implemented on top. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 72 + drivers/gpu/drm/tegra/drm.c | 9 ++ driver

[PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-14 Thread Thierry Reding
All the necessary support bits like .mode_set_base() and VBLANK are now available, so page-flipping case easily be implemented on top. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 72 + drivers/gpu/drm/tegra/drm.c | 9 ++ driver