Re: [PATCH v2 44/63] mac80211: Use memset_after() to clear tx status

2021-08-18 Thread Kees Cook
On Wed, Aug 18, 2021 at 10:06:51AM +0200, Johannes Berg wrote: > On Wed, 2021-08-18 at 09:08 +0200, Johannes Berg wrote: > > On Tue, 2021-08-17 at 23:05 -0700, Kees Cook wrote: > > > > > > @@ -275,12 +275,11 @@ static void carl9170_tx_release(struct kref *ref) > > >   if (WARN_ON_ONCE(!ar)) > > >

Re: [PATCH v2 44/63] mac80211: Use memset_after() to clear tx status

2021-08-18 Thread Johannes Berg
On Wed, 2021-08-18 at 09:08 +0200, Johannes Berg wrote: > On Tue, 2021-08-17 at 23:05 -0700, Kees Cook wrote: > > > > @@ -275,12 +275,11 @@ static void carl9170_tx_release(struct kref *ref) > >   if (WARN_ON_ONCE(!ar)) > >   return; > >   > > > > > > > > - BUILD_BUG_ON( > > -

Re: [PATCH v2 44/63] mac80211: Use memset_after() to clear tx status

2021-08-18 Thread Johannes Berg
On Tue, 2021-08-17 at 23:05 -0700, Kees Cook wrote: > > @@ -275,12 +275,11 @@ static void carl9170_tx_release(struct kref *ref) >   if (WARN_ON_ONCE(!ar)) >   return; >   > > > > - BUILD_BUG_ON( > - offsetof(struct ieee80211_tx_info, status.ack_signal) != 20); > - >

[PATCH v2 44/63] mac80211: Use memset_after() to clear tx status

2021-08-17 Thread Kees Cook
In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memset(), avoid intentionally writing across neighboring fields. Use memset_after() so memset() doesn't get confused about writing beyond the destination member that is intended to be the starting poin