Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-19 Thread Thomas Zimmermann
Hi, please see my review below. Am 07.10.22 um 14:49 schrieb Thierry Reding: From: Thierry Reding Simple framebuffers can be set up in system memory, which cannot be requested and/or I/O remapped using the I/O resource helpers. Add a separate code path that obtains system memory framebuffers

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-18 Thread Rob Herring
On Tue, Oct 18, 2022 at 5:47 AM Thierry Reding wrote: > > On Mon, Oct 17, 2022 at 01:15:59PM -0500, Rob Herring wrote: > > On Mon, Oct 17, 2022 at 9:54 AM Thierry Reding > > wrote: > > > > > > On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: > > > > Hi > > > > > > > > Am 07.10.

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-18 Thread Thierry Reding
On Tue, Oct 18, 2022 at 01:58:53PM +0200, Thomas Zimmermann wrote: > Hi Thierry > > Am 17.10.22 um 16:54 schrieb Thierry Reding: > > On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: > [...] > > > > > > That whole 'Memory Manangement' block is will be unmaintainable. Before I >

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-18 Thread Thomas Zimmermann
Hi Thierry Am 17.10.22 um 16:54 schrieb Thierry Reding: On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: [...] That whole 'Memory Manangement' block is will be unmaintainable. Before I go into a detailed review, please see my questions about the reservedmem code at the end o

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-18 Thread Thierry Reding
On Mon, Oct 17, 2022 at 01:15:59PM -0500, Rob Herring wrote: > On Mon, Oct 17, 2022 at 9:54 AM Thierry Reding > wrote: > > > > On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 07.10.22 um 14:49 schrieb Thierry Reding: > > > > From: Thierry Reding > > > >

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-17 Thread Rob Herring
On Mon, Oct 17, 2022 at 9:54 AM Thierry Reding wrote: > > On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 07.10.22 um 14:49 schrieb Thierry Reding: > > > From: Thierry Reding > > > > > > Simple framebuffers can be set up in system memory, which cannot be > > >

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-17 Thread Thierry Reding
On Mon, Oct 10, 2022 at 10:12:34AM +0200, Thomas Zimmermann wrote: > Hi > > Am 07.10.22 um 14:49 schrieb Thierry Reding: > > From: Thierry Reding > > > > Simple framebuffers can be set up in system memory, which cannot be > > requested and/or I/O remapped using the I/O resource helpers. Add a >

Re: [PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-10 Thread Thomas Zimmermann
Hi Am 07.10.22 um 14:49 schrieb Thierry Reding: From: Thierry Reding Simple framebuffers can be set up in system memory, which cannot be requested and/or I/O remapped using the I/O resource helpers. Add a separate code path that obtains system memory framebuffers from the reserved memory regio

[PATCH v2 4/7] drm/simpledrm: Add support for system memory framebuffers

2022-10-07 Thread Thierry Reding
From: Thierry Reding Simple framebuffers can be set up in system memory, which cannot be requested and/or I/O remapped using the I/O resource helpers. Add a separate code path that obtains system memory framebuffers from the reserved memory region referenced in the memory-region property. v2: ma