Re: [PATCH v2 4/5] drm/udl: Untangle .get_modes() and .detect_ctx()

2024-05-27 Thread Jani Nikula
On Fri, 10 May 2024, Thomas Zimmermann wrote: > Am 10.05.24 um 14:17 schrieb Jani Nikula: >>> + /* >>> +* The adapter sends all-zeros if no monitor has been >>> +* connected. We consider anything else a connection. >>> +*/ >>> + return memcmp(no_edid, hdr, 8) != 0; >> Nitpick, this

Re: [PATCH v2 4/5] drm/udl: Untangle .get_modes() and .detect_ctx()

2024-05-10 Thread Thomas Zimmermann
Hi Am 10.05.24 um 14:17 schrieb Jani Nikula: + /* +* The adapter sends all-zeros if no monitor has been +* connected. We consider anything else a connection. +*/ + return memcmp(no_edid, hdr, 8) != 0; Nitpick, this works, but you can drop the no_edid buf by

Re: [PATCH v2 4/5] drm/udl: Untangle .get_modes() and .detect_ctx()

2024-05-10 Thread Jani Nikula
On Wed, 10 Apr 2024, Thomas Zimmermann wrote: > Provide separate implementations of .get_modes() and .detect_ctx() > from struct drm_connector. Switch to struct drm_edid. > > Udl's .detect() helper used to fetch the EDID from the adapter and the > .get_modes() helper provided display modes from th

[PATCH v2 4/5] drm/udl: Untangle .get_modes() and .detect_ctx()

2024-04-10 Thread Thomas Zimmermann
Provide separate implementations of .get_modes() and .detect_ctx() from struct drm_connector. Switch to struct drm_edid. Udl's .detect() helper used to fetch the EDID from the adapter and the .get_modes() helper provided display modes from the data. But this relied on the DRM helpers to call the f