Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release.

2017-05-03 Thread Eric Anholt
Lucas Stach writes: > Hi Eric, > > Am Mittwoch, den 12.04.2017, 12:12 -0700 schrieb Eric Anholt: >> If we follow the typical pattern of the base class being the first >> member, we can use the default dma_fence_free function. > > Sorry, I don't like this change. > While it provides a bit of code

Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release.

2017-05-03 Thread Lucas Stach
Hi Eric, Am Mittwoch, den 12.04.2017, 12:12 -0700 schrieb Eric Anholt: > If we follow the typical pattern of the base class being the first > member, we can use the default dma_fence_free function. Sorry, I don't like this change. While it provides a bit of code simplification, it also bakes the

Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release.

2017-04-13 Thread Daniel Vetter
On Wed, Apr 12, 2017 at 12:12:01PM -0700, Eric Anholt wrote: > If we follow the typical pattern of the base class being the first > member, we can use the default dma_fence_free function. > > Signed-off-by: Eric Anholt On 3&4: Reviewed-by: Daniel Vetter > Cc: Lucas Stach > Cc: Russell King >

[PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release.

2017-04-12 Thread Eric Anholt
If we follow the typical pattern of the base class being the first member, we can use the default dma_fence_free function. Signed-off-by: Eric Anholt Cc: Lucas Stach Cc: Russell King Cc: Christian Gmeiner Cc: etna...@lists.freedesktop.org --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 11 ++-