Re: [PATCH v2 4/4] drm: zte: add VGA driver support

2017-04-11 Thread Shawn Guo
On Fri, Apr 07, 2017 at 10:43:02AM -0400, Sean Paul wrote: > On Fri, Apr 07, 2017 at 11:02:33AM +0800, Shawn Guo wrote: > > When you suggested to have a lock for DETECT_SEL register access, I > > thought we are accessing it in a read-modify-write way and thus agreed > > to add a lock. However, I j

Re: [PATCH v2 4/4] drm: zte: add VGA driver support

2017-04-07 Thread Sean Paul
On Fri, Apr 07, 2017 at 11:02:33AM +0800, Shawn Guo wrote: > On Thu, Apr 06, 2017 at 01:12:51PM -0400, Sean Paul wrote: > > On Thu, Apr 06, 2017 at 11:01:10PM +0800, Shawn Guo wrote: > > > +static int zx_vga_connector_get_modes(struct drm_connector *connector) > > > +{ > > > + struct zx_vga *vga =

Re: [PATCH v2 4/4] drm: zte: add VGA driver support

2017-04-06 Thread Shawn Guo
On Thu, Apr 06, 2017 at 01:12:51PM -0400, Sean Paul wrote: > On Thu, Apr 06, 2017 at 11:01:10PM +0800, Shawn Guo wrote: > > +static int zx_vga_connector_get_modes(struct drm_connector *connector) > > +{ > > + struct zx_vga *vga = to_zx_vga(connector); > > + unsigned long flags; > > + struct e

Re: [PATCH v2 4/4] drm: zte: add VGA driver support

2017-04-06 Thread Sean Paul
On Thu, Apr 06, 2017 at 11:01:10PM +0800, Shawn Guo wrote: > From: Shawn Guo > > It adds VGA driver support, which needs to configure corresponding VOU > interface in RGB_888 format, and thus the following changes are needed > on zx_vou. > > - Rename the CSC block of Graphic Layer a bit to make

[PATCH v2 4/4] drm: zte: add VGA driver support

2017-04-06 Thread Shawn Guo
From: Shawn Guo It adds VGA driver support, which needs to configure corresponding VOU interface in RGB_888 format, and thus the following changes are needed on zx_vou. - Rename the CSC block of Graphic Layer a bit to make it more specific, and add CSC of Channel to support RGB output. - Bypas