Re: [PATCH v2 4/4] drm/vc4: Restrict active CTM to one CRTC

2018-03-26 Thread Daniel Stone
On 26 March 2018 at 09:29, Daniel Vetter wrote: > On Sun, Mar 25, 2018 at 08:14:35PM +0200, Stefan Schake wrote: >> On Sun, Mar 25, 2018 at 10:01 AM, Daniel Stone wrote: >> > On 25 March 2018 at 02:52, Stefan Schake wrote: >> >> +static int vc4_crtc_get_ctm_fifo(struct vc4_dev *vc4) >> >> +{ >>

Re: [PATCH v2 4/4] drm/vc4: Restrict active CTM to one CRTC

2018-03-26 Thread Daniel Vetter
On Sun, Mar 25, 2018 at 08:14:35PM +0200, Stefan Schake wrote: > Hey Daniel, > > On Sun, Mar 25, 2018 at 10:01 AM, Daniel Stone wrote: > > Hi Stefan, > > > > On 25 March 2018 at 02:52, Stefan Schake wrote: > >> +static int vc4_crtc_get_ctm_fifo(struct vc4_dev *vc4) > >> +{ > >> + return VC

Re: [PATCH v2 4/4] drm/vc4: Restrict active CTM to one CRTC

2018-03-25 Thread Stefan Schake
Hey Daniel, On Sun, Mar 25, 2018 at 10:01 AM, Daniel Stone wrote: > Hi Stefan, > > On 25 March 2018 at 02:52, Stefan Schake wrote: >> +static int vc4_crtc_get_ctm_fifo(struct vc4_dev *vc4) >> +{ >> + return VC4_GET_FIELD(HVS_READ(SCALER_OLEDOFFS), >> +SCALER_OLE

Re: [PATCH v2 4/4] drm/vc4: Restrict active CTM to one CRTC

2018-03-25 Thread Daniel Stone
Hi Stefan, On 25 March 2018 at 02:52, Stefan Schake wrote: > +static int vc4_crtc_get_ctm_fifo(struct vc4_dev *vc4) > +{ > + return VC4_GET_FIELD(HVS_READ(SCALER_OLEDOFFS), > +SCALER_OLEDOFFS_DISPFIFO); > +} This needs to be managed as a global resource through

[PATCH v2 4/4] drm/vc4: Restrict active CTM to one CRTC

2018-03-24 Thread Stefan Schake
We only have one hardware block to do the CTM and need to reject attempts to enable it for multiple CRTCs simultaneously. Signed-off-by: Stefan Schake --- v2: No change drivers/gpu/drm/vc4/vc4_crtc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c