Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-10 Thread Miguel Ojeda
On Tue, Jul 9, 2024 at 5:10 PM Jocelyn Falempe wrote: > > I used to list all QR versions in an enum, but I find it a bit too much > boilerplate to ensure the version is between 1 and 40. > By transparent newtypes, you mean adding "#[repr(transparent)]" to a > struct ? > I don't plan to add more "v

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Jocelyn Falempe
On 09/07/2024 11:41, Alice Ryhl wrote: On Tue, Jul 9, 2024 at 10:45 AM Jocelyn Falempe wrote: This patch adds a new panic screen, with a QR code and the kmsg data embedded. If DRM_PANIC_SCREEN_QR_CODE_URL is set, then the kmsg data will be compressed with zlib and encoded as a numerical seg

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Jocelyn Falempe
On 09/07/2024 11:41, Miguel Ojeda wrote: Hi Jocelyn, A quick docs-only review of the Rust side (some of these apply in several cases -- I just wanted to give an overview for you to consider). Thanks, I'll fix all typo/grammar you mentioned. On Tue, Jul 9, 2024 at 10:45 AM Jocelyn Falempe

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Jocelyn Falempe
On 09/07/2024 12:12, Greg KH wrote: On Tue, Jul 09, 2024 at 12:04:02PM +0200, Jocelyn Falempe wrote: On 09/07/2024 11:12, Greg KH wrote: On Tue, Jul 09, 2024 at 11:11:35AM +0200, Greg KH wrote: On Tue, Jul 09, 2024 at 10:40:10AM +0200, Jocelyn Falempe wrote: +config DRM_PANIC_SCREEN_QR_C

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Greg KH
On Tue, Jul 09, 2024 at 12:04:02PM +0200, Jocelyn Falempe wrote: > > > On 09/07/2024 11:12, Greg KH wrote: > > On Tue, Jul 09, 2024 at 11:11:35AM +0200, Greg KH wrote: > > > On Tue, Jul 09, 2024 at 10:40:10AM +0200, Jocelyn Falempe wrote: > > > > +config DRM_PANIC_SCREEN_QR_CODE_URL > > > > +

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Jocelyn Falempe
On 09/07/2024 11:12, Greg KH wrote: On Tue, Jul 09, 2024 at 11:11:35AM +0200, Greg KH wrote: On Tue, Jul 09, 2024 at 10:40:10AM +0200, Jocelyn Falempe wrote: +config DRM_PANIC_SCREEN_QR_CODE_URL + string "Base url of the QR code in the panic screen" + depends on DRM_PANIC_SCREEN_

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Alice Ryhl
On Tue, Jul 9, 2024 at 10:45 AM Jocelyn Falempe wrote: > > This patch adds a new panic screen, with a QR code and the kmsg data > embedded. > If DRM_PANIC_SCREEN_QR_CODE_URL is set, then the kmsg data will be > compressed with zlib and encoded as a numerical segment, and appended > to the url as a

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Miguel Ojeda
Hi Jocelyn, A quick docs-only review of the Rust side (some of these apply in several cases -- I just wanted to give an overview for you to consider). On Tue, Jul 9, 2024 at 10:45 AM Jocelyn Falempe wrote: > > +//! This is a simple qr encoder for DRM panic. > +//! > +//! Due to the Panic constra

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Greg KH
On Tue, Jul 09, 2024 at 11:11:35AM +0200, Greg KH wrote: > On Tue, Jul 09, 2024 at 10:40:10AM +0200, Jocelyn Falempe wrote: > > +config DRM_PANIC_SCREEN_QR_CODE_URL > > + string "Base url of the QR code in the panic screen" > > + depends on DRM_PANIC_SCREEN_QR_CODE > > + help > > + This o

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Greg KH
On Tue, Jul 09, 2024 at 10:40:10AM +0200, Jocelyn Falempe wrote: > +config DRM_PANIC_SCREEN_QR_CODE_URL > + string "Base url of the QR code in the panic screen" > + depends on DRM_PANIC_SCREEN_QR_CODE > + help > + This option sets the base url to report the kernel panic. If it's s

[PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Jocelyn Falempe
This patch adds a new panic screen, with a QR code and the kmsg data embedded. If DRM_PANIC_SCREEN_QR_CODE_URL is set, then the kmsg data will be compressed with zlib and encoded as a numerical segment, and appended to the url as a url parameter. This allows to save space, and put about ~7500 bytes