Re: [PATCH v2 3/8] accel/qaic: Add MHI controller

2023-03-03 Thread Stanislaw Gruszka
On Wed, Mar 01, 2023 at 09:09:57AM -0700, Jeffrey Hugo wrote: > On 2/28/2023 4:52 AM, Stanislaw Gruszka wrote: > > On Mon, Feb 06, 2023 at 08:41:40AM -0700, Jeffrey Hugo wrote: > > > + mhi_cntl = kzalloc(sizeof(*mhi_cntl), GFP_KERNEL); > > [snip] > > > + mhi_cntl->irq = kmalloc(sizeof(*mhi_cntl->ir

Re: [PATCH v2 3/8] accel/qaic: Add MHI controller

2023-03-01 Thread Jeffrey Hugo
On 2/28/2023 4:52 AM, Stanislaw Gruszka wrote: On Mon, Feb 06, 2023 at 08:41:40AM -0700, Jeffrey Hugo wrote: + mhi_cntl = kzalloc(sizeof(*mhi_cntl), GFP_KERNEL); [snip] + mhi_cntl->irq = kmalloc(sizeof(*mhi_cntl->irq), GFP_KERNEL); I recommend usage of devm_kzalloc(), devm_kmallo

Re: [PATCH v2 3/8] accel/qaic: Add MHI controller

2023-02-28 Thread Stanislaw Gruszka
On Mon, Feb 06, 2023 at 08:41:40AM -0700, Jeffrey Hugo wrote: > + mhi_cntl = kzalloc(sizeof(*mhi_cntl), GFP_KERNEL); [snip] > + mhi_cntl->irq = kmalloc(sizeof(*mhi_cntl->irq), GFP_KERNEL); I recommend usage of devm_kzalloc(), devm_kmalloc() for those to simplify error and exit paths. Rega

[PATCH v2 3/8] accel/qaic: Add MHI controller

2023-02-06 Thread Jeffrey Hugo
An AIC100 device contains a MHI interface with a number of different channels for controlling different aspects of the device. The MHI controller works with the MHI bus to enable and drive that interface. AIC100 uses the BHI protocol in PBL to load SBL. The MHI controller expects the sbl to be l