Re: [PATCH v2 3/3] drm/xe: Implement and use the drm_pagemap populate_mm op

2025-06-13 Thread Thomas Hellström
On Thu, 2025-06-05 at 15:16 -0700, Matthew Brost wrote: > On Wed, Jun 04, 2025 at 11:35:36AM +0200, Thomas Hellström wrote: > > Add runtime PM since we might call populate_mm on a foreign device. > > Also create the VRAM bos as ttm_bo_type_kernel. This avoids the > > initial clearing and the creati

Re: [PATCH v2 3/3] drm/xe: Implement and use the drm_pagemap populate_mm op

2025-06-05 Thread Matthew Brost
On Wed, Jun 04, 2025 at 11:35:36AM +0200, Thomas Hellström wrote: > Add runtime PM since we might call populate_mm on a foreign device. > Also create the VRAM bos as ttm_bo_type_kernel. This avoids the > initial clearing and the creation of an mmap handle. > I didn't read this part - skipping the

Re: [PATCH v2 3/3] drm/xe: Implement and use the drm_pagemap populate_mm op

2025-06-05 Thread Thomas Hellström
On Wed, 2025-06-04 at 08:04 -0700, Matthew Brost wrote: > On Wed, Jun 04, 2025 at 11:35:36AM +0200, Thomas Hellström wrote: > > Add runtime PM since we might call populate_mm on a foreign device. > > I think taking a runtime PM will fix hard to hit splat [1] too. > > [1] > https://patchwork.freed

Re: [PATCH v2 3/3] drm/xe: Implement and use the drm_pagemap populate_mm op

2025-06-04 Thread Matthew Brost
On Wed, Jun 04, 2025 at 11:35:36AM +0200, Thomas Hellström wrote: > Add runtime PM since we might call populate_mm on a foreign device. I think taking a runtime PM will fix hard to hit splat [1] too. [1] https://patchwork.freedesktop.org/patch/648954/?series=147849&rev=1 > Also create the VRAM b

[PATCH v2 3/3] drm/xe: Implement and use the drm_pagemap populate_mm op

2025-06-04 Thread Thomas Hellström
Add runtime PM since we might call populate_mm on a foreign device. Also create the VRAM bos as ttm_bo_type_kernel. This avoids the initial clearing and the creation of an mmap handle. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/drm_pagemap.c | 1 + drivers/gpu/drm/xe/xe_svm.c | 104