Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-22 Thread Jagan Teki
Hi Dillon, On Thu, Jul 22, 2021 at 4:38 AM Dillon Min wrote: > > Hi Jagan > > Thanks for your time to review my code. > > On Wed, 21 Jul 2021 at 23:48, Jagan Teki wrote: > > > > On Wed, Jul 21, 2021 at 1:11 PM wrote: > > > > > > From: Dillon Min > > > > > > This driver combine tiny/ili9341.c m

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-22 Thread Dillon Min
Hi Noralf, On Thu, 22 Jul 2021 at 15:03, Noralf Trønnes wrote: > > > > Den 22.07.2021 04.07, skrev Dillon Min: > > Hi Noralf > > > > Thanks for your time to review my patch. > > > > On Thu, 22 Jul 2021 at 01:42, Noralf Trønnes wrote: > >> > >> > >> > >> Den 21.07.2021 09.41, skrev dillon.min...@

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-22 Thread Noralf Trønnes
Den 22.07.2021 04.07, skrev Dillon Min: > Hi Noralf > > Thanks for your time to review my patch. > > On Thu, 22 Jul 2021 at 01:42, Noralf Trønnes wrote: >> >> >> >> Den 21.07.2021 09.41, skrev dillon.min...@gmail.com: >>> From: Dillon Min >>> >>> This driver combine tiny/ili9341.c mipi_dbi_i

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Dillon Min
Hi Noralf Thanks for your time to review my patch. On Thu, 22 Jul 2021 at 01:42, Noralf Trønnes wrote: > > > > Den 21.07.2021 09.41, skrev dillon.min...@gmail.com: > > From: Dillon Min > > > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > > with mipi_dpi_interface driver, can s

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Dillon Min
Hi Sam, Thanks for your time on my code review. On Thu, 22 Jul 2021 at 00:56, Sam Ravnborg wrote: > > Hi Dillon, > > On Wed, Jul 21, 2021 at 03:41:28PM +0800, dillon.min...@gmail.com wrote: > > From: Dillon Min > > > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > > with mipi_d

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Dillon Min
Hi Jagan Thanks for your time to review my code. On Wed, 21 Jul 2021 at 23:48, Jagan Teki wrote: > > On Wed, Jul 21, 2021 at 1:11 PM wrote: > > > > From: Dillon Min > > > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > > with mipi_dpi_interface driver, can support ili9341 with

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Noralf Trønnes
Den 21.07.2021 09.41, skrev dillon.min...@gmail.com: > From: Dillon Min > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > with mipi_dpi_interface driver, can support ili9341 with serial > mode or parallel rgb interface mode by register configuration. > > Cc: Linus Walleij >

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Sam Ravnborg
Hi Dillon, On Wed, Jul 21, 2021 at 03:41:28PM +0800, dillon.min...@gmail.com wrote: > From: Dillon Min > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > with mipi_dpi_interface driver, can support ili9341 with serial > mode or parallel rgb interface mode by register configuratio

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Jagan Teki
On Wed, Jul 21, 2021 at 1:11 PM wrote: > > From: Dillon Min > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > with mipi_dpi_interface driver, can support ili9341 with serial > mode or parallel rgb interface mode by register configuration. > > Cc: Linus Walleij > Signed-off-by: D

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Dillon Min
On Wed, 21 Jul 2021 at 22:02, Linus Walleij wrote: > > On Wed, Jul 21, 2021 at 9:41 AM wrote: > > > From: Dillon Min > > > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > > with mipi_dpi_interface driver, can support ili9341 with serial > > mode or parallel rgb interface mode by

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Linus Walleij
On Wed, Jul 21, 2021 at 9:41 AM wrote: > From: Dillon Min > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > with mipi_dpi_interface driver, can support ili9341 with serial > mode or parallel rgb interface mode by register configuration. > > Cc: Linus Walleij > Signed-off-by: Di

[PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread dillon . minfei
From: Dillon Min This driver combine tiny/ili9341.c mipi_dbi_interface driver with mipi_dpi_interface driver, can support ili9341 with serial mode or parallel rgb interface mode by register configuration. Cc: Linus Walleij Signed-off-by: Dillon Min --- changes in v2: - replace vcc regulator to