Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-02-03 Thread Maxime Ripard
Hi Sam, On Wed, Feb 02, 2022 at 06:14:16PM +0100, Sam Ravnborg wrote: > Hi Noralf, > > > > > > > Parts of it is ergonomics I guess. We're used to having all those > > > properties either in the DT or the driver, but here we introduce a new > > > way that isn't done anywhere else. > > > > > > An

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-02-02 Thread Sam Ravnborg
Hi Noralf, > > > > Parts of it is ergonomics I guess. We're used to having all those > > properties either in the DT or the driver, but here we introduce a new > > way that isn't done anywhere else. > > > > And I don't see any real downside to putting it in the DT? It's going to > > be in an ove

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-02-02 Thread Noralf Trønnes
Den 02.02.2022 11.09, skrev Maxime Ripard: > On Thu, Jan 27, 2022 at 06:53:48PM +0100, Noralf Trønnes wrote: +struct panel_mipi_dbi_config { + /* Magic string: panel_mipi_dbi_magic */ + u8 magic[15]; + + /* Config file format version */ + u8 file_format_version;

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-02-02 Thread Maxime Ripard
On Thu, Jan 27, 2022 at 06:53:48PM +0100, Noralf Trønnes wrote: > >> +struct panel_mipi_dbi_config { > >> + /* Magic string: panel_mipi_dbi_magic */ > >> + u8 magic[15]; > >> + > >> + /* Config file format version */ > >> + u8 file_format_version; > >> + > >> + /* Width in pixels */ > >> + __

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-27 Thread Noralf Trønnes
Den 27.01.2022 20.59, skrev Sam Ravnborg: > Hi Noralf, > > On Tue, Jan 25, 2022 at 06:57:00PM +0100, Noralf Trønnes wrote: >> Add a driver that will work with most MIPI DBI compatible SPI panels. >> This avoids adding a driver for every new MIPI DBI compatible controller >> that is to be used b

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-27 Thread Sam Ravnborg
Hi Noralf, On Tue, Jan 25, 2022 at 06:57:00PM +0100, Noralf Trønnes wrote: > Add a driver that will work with most MIPI DBI compatible SPI panels. > This avoids adding a driver for every new MIPI DBI compatible controller > that is to be used by Linux. The 'compatible' Device Tree property with >

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-27 Thread Noralf Trønnes
Den 27.01.2022 18.19, skrev David Lechner: > On 1/25/22 11:57 AM, Noralf Trønnes wrote: >> Add a driver that will work with most MIPI DBI compatible SPI panels. >> This avoids adding a driver for every new MIPI DBI compatible controller >> that is to be used by Linux. The 'compatible' Device Tre

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-27 Thread Noralf Trønnes
Den 27.01.2022 11.04, skrev Maxime Ripard: > On Tue, Jan 25, 2022 at 06:57:00PM +0100, Noralf Trønnes wrote: >> Add a driver that will work with most MIPI DBI compatible SPI panels. >> This avoids adding a driver for every new MIPI DBI compatible controller >> that is to be used by Linux. The 'c

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-27 Thread David Lechner
On 1/25/22 11:57 AM, Noralf Trønnes wrote: Add a driver that will work with most MIPI DBI compatible SPI panels. This avoids adding a driver for every new MIPI DBI compatible controller that is to be used by Linux. The 'compatible' Device Tree property with a '.bin' suffix will be used to load a

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-27 Thread Maxime Ripard
On Tue, Jan 25, 2022 at 06:57:00PM +0100, Noralf Trønnes wrote: > Add a driver that will work with most MIPI DBI compatible SPI panels. > This avoids adding a driver for every new MIPI DBI compatible controller > that is to be used by Linux. The 'compatible' Device Tree property with > a '.bin' suf

[PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-01-25 Thread Noralf Trønnes
Add a driver that will work with most MIPI DBI compatible SPI panels. This avoids adding a driver for every new MIPI DBI compatible controller that is to be used by Linux. The 'compatible' Device Tree property with a '.bin' suffix will be used to load a firmware file that contains the controller co