Re: [PATCH v2 2/8] drm/panfrost: Rework runtime PM initialization

2019-08-23 Thread Rob Herring
On Fri, Aug 23, 2019 at 5:54 AM Robin Murphy wrote: > > On 23/08/2019 03:12, Rob Herring wrote: > > There's a few issues with the runtime PM initialization. > > > > The documentation states pm_runtime_set_active() should be called before > > pm_runtime_enable(). The pm_runtime_put_autosuspend() co

Re: [PATCH v2 2/8] drm/panfrost: Rework runtime PM initialization

2019-08-23 Thread Robin Murphy
On 23/08/2019 03:12, Rob Herring wrote: There's a few issues with the runtime PM initialization. The documentation states pm_runtime_set_active() should be called before pm_runtime_enable(). The pm_runtime_put_autosuspend() could suspend the GPU before panfrost_perfcnt_init() is called which tou

[PATCH v2 2/8] drm/panfrost: Rework runtime PM initialization

2019-08-22 Thread Rob Herring
There's a few issues with the runtime PM initialization. The documentation states pm_runtime_set_active() should be called before pm_runtime_enable(). The pm_runtime_put_autosuspend() could suspend the GPU before panfrost_perfcnt_init() is called which touches the h/w. The autosuspend delay keeps