Re: [PATCH v2 2/7] drm/vkms: Add support for multy-planar framebuffers

2024-02-02 Thread Arthur Grillo
On 01/02/24 14:38, Louis Chauvet wrote: >> >> /* >> @@ -23,27 +23,25 @@ static size_t pixel_offset(const struct vkms_frame_info >> *frame_info, int x, int >> * @frame_info: Buffer metadata >> * @x: The x(width) coordinate of the 2D buffer >> * @y: The y(Heigth) coordinate of the 2D buf

Re: [PATCH v2 2/7] drm/vkms: Add support for multy-planar framebuffers

2024-02-01 Thread Louis Chauvet
Hello, I think there are some bugs in this implementation of multi-planar support (and not mylty-planar, there is a typo in the title), especially for the "new" drm_format_info description which uses block_w and block_h. I will propose two patches [1] solving these issues and hopefully also si

[PATCH v2 2/7] drm/vkms: Add support for multy-planar framebuffers

2024-01-10 Thread Arthur Grillo
Add support to multy-planar formats by adding an index argument to the framebuffer data access functions. Also, give all the planes to the conversion functions. This, for now, should be noop, as all the supported formats have only one plane. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/vkms