Re: [PATCH v2 2/6] drm: rcar-du: Add CRTC standby helpers

2019-05-12 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Fri, Mar 15, 2019 at 05:01:06PM +, Kieran Bingham wrote: > Provide helpers to manage the power state, and initial configuration of > the CRTC. I would add a sentence here to mention that these helpers operate from the atomic commit tail handler, and res

[PATCH v2 2/6] drm: rcar-du: Add CRTC standby helpers

2019-03-15 Thread Kieran Bingham
Provide helpers to manage the power state, and initial configuration of the CRTC. rcar_du_crtc_get() and rcar_du_crtc_get() are no longer used, and are removed, simplifying the implementation and removing the initialized flag which was needed to track the state of the CRTC. Signed-off-by: Kieran