Re: [PATCH v2 2/4] drm/sun4i: tcon: Refactor the LVDS and panel probing

2020-10-06 Thread Maxime Ripard
Hi Chen-Yu, Sorry for the delay On Sat, Aug 29, 2020 at 02:43:53PM +0800, Chen-Yu Tsai wrote: > > +static int sun4i_tcon_register_panel(struct drm_device *drm, > > +struct sun4i_tcon *tcon) > > +{ > > + struct device_node *companion; > > + struct de

Re: [PATCH v2 2/4] drm/sun4i: tcon: Refactor the LVDS and panel probing

2020-10-05 Thread Chen-Yu Tsai
On Mon, Oct 5, 2020 at 10:19 PM Maxime Ripard wrote: > > Hi Chen-Yu, > > Sorry for the delay > > On Sat, Aug 29, 2020 at 02:43:53PM +0800, Chen-Yu Tsai wrote: > > > +static int sun4i_tcon_register_panel(struct drm_device *drm, > > > +struct sun4i_tcon *tcon) > >

Re: [PATCH v2 2/4] drm/sun4i: tcon: Refactor the LVDS and panel probing

2020-08-31 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Thu, Jul 30, 2020 at 11:35:02AM +0200, Maxime Ripard wrote: > The current code to parse the DT, deal with the older device trees, and > register either the RGB or LVDS output has so far grown organically into > the bind function and has become quite hard to

Re: [PATCH v2 2/4] drm/sun4i: tcon: Refactor the LVDS and panel probing

2020-08-28 Thread Chen-Yu Tsai
On Thu, Jul 30, 2020 at 5:35 PM Maxime Ripard wrote: > > The current code to parse the DT, deal with the older device trees, and > register either the RGB or LVDS output has so far grown organically into > the bind function and has become quite hard to extend properly. > > Let's move it into a sin

[PATCH v2 2/4] drm/sun4i: tcon: Refactor the LVDS and panel probing

2020-07-31 Thread Maxime Ripard
The current code to parse the DT, deal with the older device trees, and register either the RGB or LVDS output has so far grown organically into the bind function and has become quite hard to extend properly. Let's move it into a single function that grabs all the resources it needs and registers