Re: [PATCH v2 2/4] drm/nvdla: Add driver support for NVDLA

2022-04-28 Thread Thierry Reding
On Thu, Apr 28, 2022 at 05:18:13PM +0200, Thierry Reding wrote: > On Tue, Apr 26, 2022 at 02:07:59PM +0800, Cai Huoqing wrote: > [...] > > diff --git a/drivers/gpu/drm/nvdla/nvdla_drv.c > > b/drivers/gpu/drm/nvdla/nvdla_drv.c > > I'll look at this from an architectural level and leave it to other

Re: [PATCH v2 2/4] drm/nvdla: Add driver support for NVDLA

2022-04-28 Thread Thierry Reding
On Tue, Apr 26, 2022 at 02:07:59PM +0800, Cai Huoqing wrote: [...] > diff --git a/drivers/gpu/drm/nvdla/nvdla_drv.c > b/drivers/gpu/drm/nvdla/nvdla_drv.c I'll look at this from an architectural level and leave it to other experts to review the more technical things. [...] > +static struct nvdla_