Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-16 Thread Pekka Paalanen
On Mon, 15 Oct 2018 12:02:14 -0400 "Kazlauskas, Nicholas" wrote: > On 10/15/2018 09:57 AM, Pekka Paalanen wrote: > > On Fri, 12 Oct 2018 08:58:23 -0400 > > "Kazlauskas, Nicholas" wrote: > > > >> On 10/12/2018 07:20 AM, Koenig, Christian wrote: > >>> Am 12.10.2018 um 11:21 schrieb Pekka Paal

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-15 Thread Kazlauskas, Nicholas
On 10/15/2018 09:57 AM, Pekka Paalanen wrote: On Fri, 12 Oct 2018 08:58:23 -0400 "Kazlauskas, Nicholas" wrote: On 10/12/2018 07:20 AM, Koenig, Christian wrote: Am 12.10.2018 um 11:21 schrieb Pekka Paalanen: On Fri, 12 Oct 2018 07:35:57 + "Koenig, Christian" wrote: Am 12.10.2018 um 0

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-15 Thread Pekka Paalanen
On Fri, 12 Oct 2018 08:58:23 -0400 "Kazlauskas, Nicholas" wrote: > On 10/12/2018 07:20 AM, Koenig, Christian wrote: > > Am 12.10.2018 um 11:21 schrieb Pekka Paalanen: > >> On Fri, 12 Oct 2018 07:35:57 + > >> "Koenig, Christian" wrote: > >> > >>> Am 12.10.2018 um 09:23 schrieb Pekka Paala

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-12 Thread Kazlauskas, Nicholas
On 10/12/2018 07:20 AM, Koenig, Christian wrote: Am 12.10.2018 um 11:21 schrieb Pekka Paalanen: On Fri, 12 Oct 2018 07:35:57 + "Koenig, Christian" wrote: Am 12.10.2018 um 09:23 schrieb Pekka Paalanen: On Wed, 10 Oct 2018 09:35:50 -0400 "Kazlauskas, Nicholas" wrote: The patches I've

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-12 Thread Koenig, Christian
Am 12.10.2018 um 11:21 schrieb Pekka Paalanen: > On Fri, 12 Oct 2018 07:35:57 + > "Koenig, Christian" wrote: > >> Am 12.10.2018 um 09:23 schrieb Pekka Paalanen: >>> On Wed, 10 Oct 2018 09:35:50 -0400 >>> "Kazlauskas, Nicholas" wrote: >>> The patches I've put out target this use case m

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-12 Thread Pekka Paalanen
On Fri, 12 Oct 2018 07:35:57 + "Koenig, Christian" wrote: > Am 12.10.2018 um 09:23 schrieb Pekka Paalanen: > > On Wed, 10 Oct 2018 09:35:50 -0400 > > "Kazlauskas, Nicholas" wrote: > > > >> The patches I've put out target this use case mostly because of the > >> benefit for a relatively sim

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-12 Thread Koenig, Christian
Am 12.10.2018 um 09:23 schrieb Pekka Paalanen: > On Wed, 10 Oct 2018 09:35:50 -0400 > "Kazlauskas, Nicholas" wrote: > >> The patches I've put out target this use case mostly because of the >> benefit for a relatively simple interface. VRR can and has been used in >> more ways that this, however. >

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-12 Thread Pekka Paalanen
On Wed, 10 Oct 2018 09:35:50 -0400 "Kazlauskas, Nicholas" wrote: > The patches I've put out target this use case mostly because of the > benefit for a relatively simple interface. VRR can and has been used in > more ways that this, however. > > An example usecase that differs from this would a

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-10 Thread Kazlauskas, Nicholas
On 10/10/2018 03:14 AM, Pekka Paalanen wrote: On Fri, 5 Oct 2018 12:21:20 -0400 "Kazlauskas, Nicholas" wrote: On 10/05/2018 04:10 AM, Pekka Paalanen wrote: Hi, I have a somewhat of my own view on what would be involved with VRR, and I'd like to hear what you think of it. Comments inline. O

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-10 Thread Pekka Paalanen
On Fri, 5 Oct 2018 12:21:20 -0400 "Kazlauskas, Nicholas" wrote: > On 10/05/2018 04:10 AM, Pekka Paalanen wrote: > > Hi, > > > > I have a somewhat of my own view on what would be involved with VRR, > > and I'd like to hear what you think of it. Comments inline. > > > > > > On Tue, 25 Sep 2018 0

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-08 Thread Michel Dänzer
On 2018-10-05 7:48 p.m., Kazlauskas, Nicholas wrote: > On 10/05/2018 12:56 PM, Michel Dänzer wrote: >> On 2018-10-05 6:21 p.m., Kazlauskas, Nicholas wrote: >>> On 10/05/2018 04:10 AM, Pekka Paalanen wrote: I also believe that it would be useful to expose vmin/vmax to userspace as pro

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-05 Thread Kazlauskas, Nicholas
On 10/05/2018 12:56 PM, Michel Dänzer wrote: On 2018-10-05 6:21 p.m., Kazlauskas, Nicholas wrote: On 10/05/2018 04:10 AM, Pekka Paalanen wrote: 2. User preference A toggle on the desktop environment's display settings application to allow or disallow VRR. After all, video mode c

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-05 Thread Michel Dänzer
On 2018-10-05 6:21 p.m., Kazlauskas, Nicholas wrote: > On 10/05/2018 04:10 AM, Pekka Paalanen wrote: >> >> 2. User preference >> A toggle on the desktop environment's display settings >> application to allow or disallow VRR. After all, video mode >> configuration is here too, and ideall

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-05 Thread Kazlauskas, Nicholas
On 10/05/2018 04:10 AM, Pekka Paalanen wrote: Hi, I have a somewhat of my own view on what would be involved with VRR, and I'd like to hear what you think of it. Comments inline. On Tue, 25 Sep 2018 09:51:37 -0400 "Kazlauskas, Nicholas" wrote: On 09/24/2018 04:26 PM, Ville Syrjälä wrote: O

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-05 Thread Pekka Paalanen
Hi, I have a somewhat of my own view on what would be involved with VRR, and I'd like to hear what you think of it. Comments inline. On Tue, 25 Sep 2018 09:51:37 -0400 "Kazlauskas, Nicholas" wrote: > On 09/24/2018 04:26 PM, Ville Syrjälä wrote: > > On Mon, Sep 24, 2018 at 03:06:02PM -0400, Kaz

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-01 Thread Daniel Vetter
On Tue, Sep 25, 2018 at 06:28:17PM +0300, Ville Syrjälä wrote: > On Tue, Sep 25, 2018 at 04:35:59PM +0200, Michel Dänzer wrote: > > On 2018-09-25 4:04 p.m., Ville Syrjälä wrote: > > > On Tue, Sep 25, 2018 at 03:28:28PM +0200, Michel Dänzer wrote: > > >> On 2018-09-24 10:26 p.m., Ville Syrjälä wrote

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-09-25 Thread Ville Syrjälä
On Tue, Sep 25, 2018 at 04:35:59PM +0200, Michel Dänzer wrote: > On 2018-09-25 4:04 p.m., Ville Syrjälä wrote: > > On Tue, Sep 25, 2018 at 03:28:28PM +0200, Michel Dänzer wrote: > >> On 2018-09-24 10:26 p.m., Ville Syrjälä wrote: > >>> On Mon, Sep 24, 2018 at 03:06:02PM -0400, Kazlauskas, Nicholas

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-09-25 Thread Michel Dänzer
On 2018-09-25 4:04 p.m., Ville Syrjälä wrote: > On Tue, Sep 25, 2018 at 03:28:28PM +0200, Michel Dänzer wrote: >> On 2018-09-24 10:26 p.m., Ville Syrjälä wrote: >>> On Mon, Sep 24, 2018 at 03:06:02PM -0400, Kazlauskas, Nicholas wrote: On 09/24/2018 02:38 PM, Ville Syrjälä wrote: > > Ac

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-09-25 Thread Ville Syrjälä
On Tue, Sep 25, 2018 at 03:28:28PM +0200, Michel Dänzer wrote: > On 2018-09-24 10:26 p.m., Ville Syrjälä wrote: > > On Mon, Sep 24, 2018 at 03:06:02PM -0400, Kazlauskas, Nicholas wrote: > >> On 09/24/2018 02:38 PM, Ville Syrjälä wrote: > >>> > >>> Actually I don't understand why this per-crtc thing

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-09-25 Thread Kazlauskas, Nicholas
On 09/24/2018 04:26 PM, Ville Syrjälä wrote: On Mon, Sep 24, 2018 at 03:06:02PM -0400, Kazlauskas, Nicholas wrote: On 09/24/2018 02:38 PM, Ville Syrjälä wrote: On Mon, Sep 24, 2018 at 02:15:36PM -0400, Nicholas Kazlauskas wrote: Variable refresh rate algorithms have typically been enabled only

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-09-25 Thread Michel Dänzer
On 2018-09-24 10:26 p.m., Ville Syrjälä wrote: > On Mon, Sep 24, 2018 at 03:06:02PM -0400, Kazlauskas, Nicholas wrote: >> On 09/24/2018 02:38 PM, Ville Syrjälä wrote: >>> >>> Actually I don't understand why this per-crtc thing is being added at >>> all. You already have the prop on the connector. W

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-09-24 Thread Ville Syrjälä
On Mon, Sep 24, 2018 at 03:06:02PM -0400, Kazlauskas, Nicholas wrote: > On 09/24/2018 02:38 PM, Ville Syrjälä wrote: > > On Mon, Sep 24, 2018 at 02:15:36PM -0400, Nicholas Kazlauskas wrote: > >> Variable refresh rate algorithms have typically been enabled only > >> when the display is covered by a

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-09-24 Thread Kazlauskas, Nicholas
On 09/24/2018 02:38 PM, Ville Syrjälä wrote: On Mon, Sep 24, 2018 at 02:15:36PM -0400, Nicholas Kazlauskas wrote: Variable refresh rate algorithms have typically been enabled only when the display is covered by a single source of content. This patch introduces a new default CRTC property that h

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-09-24 Thread Ville Syrjälä
On Mon, Sep 24, 2018 at 02:15:36PM -0400, Nicholas Kazlauskas wrote: > Variable refresh rate algorithms have typically been enabled only > when the display is covered by a single source of content. > > This patch introduces a new default CRTC property that helps > hint to the driver when the CRTC

[PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-09-24 Thread Nicholas Kazlauskas
Variable refresh rate algorithms have typically been enabled only when the display is covered by a single source of content. This patch introduces a new default CRTC property that helps hint to the driver when the CRTC composition is suitable for variable refresh rate algorithms. Userspace can set