Re: [PATCH v2 2/3] drm: Add ASPEED GFX driver

2019-04-02 Thread Joel Stanley
On Tue, 2 Apr 2019 at 06:26, Sam Ravnborg wrote: > > Hi Joel > > > index ..fb56e425bd48 > > --- /dev/null > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > @@ -0,0 +1,104 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +// Copyright 2018 IBM Corporation > > + > > +#include > > +#incl

Re: [PATCH v2 2/3] drm: Add ASPEED GFX driver

2019-04-01 Thread Sam Ravnborg
Hi Joel > index ..fb56e425bd48 > --- /dev/null > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > @@ -0,0 +1,104 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +// Copyright 2018 IBM Corporation > + > +#include > +#include A drmP.h include was left here, can we have this removed too. > +

[PATCH v2 2/3] drm: Add ASPEED GFX driver

2019-04-01 Thread Joel Stanley
This driver is for the ASPEED BMC SoC's GFX display hardware. This driver runs on the ARM based BMC systems, unlike the ast driver which runs on a host CPU and is is for a PCI graphics device. Signed-off-by: Joel Stanley Acked-by: Daniel Vetter Reviewed-by: Noralf Trønnes -- v2: Use drm_gem_fb