Re: [PATCH v2 2/3] drm/vkms: Add basic CRTC initialization

2018-05-24 Thread Haneen Mohammed
On Wed, May 23, 2018 at 10:53:33AM +0200, Daniel Vetter wrote: > On Sun, May 20, 2018 at 09:22:31AM +0300, Haneen Mohammed wrote: > > On Wed, May 16, 2018 at 08:56:21PM -0300, Rodrigo Siqueira wrote: > > > This commit adds the essential infrastructure for around CRTCs which > > > is composed of: a

Re: [PATCH v2 2/3] drm/vkms: Add basic CRTC initialization

2018-05-23 Thread Daniel Vetter
On Sun, May 20, 2018 at 09:22:31AM +0300, Haneen Mohammed wrote: > On Wed, May 16, 2018 at 08:56:21PM -0300, Rodrigo Siqueira wrote: > > This commit adds the essential infrastructure for around CRTCs which > > is composed of: a new data struct for output data information, a > > function for creatin

Re: [PATCH v2 2/3] drm/vkms: Add basic CRTC initialization

2018-05-21 Thread Haneen Mohammed
On Sun, May 20, 2018 at 11:28:37AM -0300, Rodrigo Siqueira wrote: > Hi Haneen, > > Thanks for the feedback :) > > On 05/20, Haneen Mohammed wrote: > > On Wed, May 16, 2018 at 08:56:21PM -0300, Rodrigo Siqueira wrote: > > > This commit adds the essential infrastructure for around CRTCs which > > >

Re: [PATCH v2 2/3] drm/vkms: Add basic CRTC initialization

2018-05-21 Thread Haneen Mohammed
On Wed, May 16, 2018 at 08:56:21PM -0300, Rodrigo Siqueira wrote: > This commit adds the essential infrastructure for around CRTCs which > is composed of: a new data struct for output data information, a > function for creating planes, and a simple encoder attached to the > connector. Finally, due

Re: [PATCH v2 2/3] drm/vkms: Add basic CRTC initialization

2018-05-20 Thread Rodrigo Siqueira
A, I got it! Thanks a lot Haneen :) On Sun, May 20, 2018 at 1:44 PM, Haneen Mohammed wrote: > On Sun, May 20, 2018 at 11:28:37AM -0300, Rodrigo Siqueira wrote: > > Hi Haneen, > > > > Thanks for the feedback :) > > > > On 05/20, Haneen Mohammed wrote: > > > On Wed, May 16, 2018 at 08:56:21PM

Re: [PATCH v2 2/3] drm/vkms: Add basic CRTC initialization

2018-05-20 Thread Rodrigo Siqueira
Hi Haneen, Thanks for the feedback :) On 05/20, Haneen Mohammed wrote: > On Wed, May 16, 2018 at 08:56:21PM -0300, Rodrigo Siqueira wrote: > > This commit adds the essential infrastructure for around CRTCs which > > is composed of: a new data struct for output data information, a > > function for

[PATCH v2 2/3] drm/vkms: Add basic CRTC initialization

2018-05-16 Thread Rodrigo Siqueira
This commit adds the essential infrastructure for around CRTCs which is composed of: a new data struct for output data information, a function for creating planes, and a simple encoder attached to the connector. Finally, due to the introduction of a new initialization function, connectors were move