Re: [PATCH v2 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

2017-11-28 Thread Nickey Yang
Hi Archit, On 2017年11月28日 14:27, Archit Taneja wrote: Hi, Thanks a lot for working on this. Some comments below. Those comments have fixed in patch_v3 https://patchwork.kernel.org/patch/10079857/ Thanks for review. On 11/28/2017 07:25 AM, Nickey Yang wrote: Add the ROCKCHIP DSI controller

Re: [PATCH v2 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

2017-11-27 Thread Archit Taneja
Hi, Thanks a lot for working on this. Some comments below. On 11/28/2017 07:25 AM, Nickey Yang wrote: Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/Kconfig|

Re: [PATCH v2 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

2017-11-27 Thread Brian Norris
Hi Nickey, Thanks for the quick version 2. You've fixed most of the the problems I pointed out, but you've missed at least one. On Tue, Nov 28, 2017 at 09:55:24AM +0800, Nickey Yang wrote: > Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare > MIPI DSI host controller bridge

[PATCH v2 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

2017-11-27 Thread Nickey Yang
Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/Kconfig|2 +- drivers/gpu/drm/rockchip/Makefile |2 +- drivers/gpu/drm/rockchip/dw-mipi-dsi.c