Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-19 Thread Herbert Xu
On Thu, Apr 17, 2025 at 09:02:15PM +0530, Gupta, Nipun wrote: > > Thanks for pointing out to the C file, but as these these system calls can > support only synchronous operations, precludes their use for asynchronous > operations. In the TLS handshakes, where multiple connections occur > simultaneo

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-17 Thread Gupta, Nipun
On 12-04-2025 06:53, Herbert Xu wrote: On Fri, Apr 11, 2025 at 11:50:54PM +0530, Gupta, Nipun wrote: AFAIU after looking into it, the keyring subsystem is not to perform the data operations, but for managing keys for these operations. Kindly correct me if I am wrong here. Have a look at s

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-16 Thread Gupta, Nipun
On 14-04-2025 00:22, Lukas Wunner wrote: On Fri, Apr 11, 2025 at 10:21:03AM +0530, Gupta, Nipun wrote: On 10-04-2025 13:06, Krzysztof Kozlowski wrote: On Wed, Apr 09, 2025 at 11:00:32PM GMT, Nipun Gupta wrote: The AMD PKI accelerator driver provides a accel interface to interact with the de

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-16 Thread kernel test robot
or-AMD-PKI-accelerator/20250410-013224 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20250409173033.2261755-2-nipun.gupta%40amd.com patch subject: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator config: x86_64-rand

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-13 Thread Lukas Wunner
On Fri, Apr 11, 2025 at 10:21:03AM +0530, Gupta, Nipun wrote: > On 10-04-2025 13:06, Krzysztof Kozlowski wrote: > > On Wed, Apr 09, 2025 at 11:00:32PM GMT, Nipun Gupta wrote: > > > The AMD PKI accelerator driver provides a accel interface to interact > > > with the device for offloading and acceler

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-11 Thread Herbert Xu
On Fri, Apr 11, 2025 at 11:50:54PM +0530, Gupta, Nipun wrote: > > AFAIU after looking into it, the keyring subsystem is not to perform the > data operations, but for managing keys for these operations. Kindly correct > me if I am wrong here. Have a look at security/keys/keyctl_pkey.c Cheers, --

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-11 Thread Gupta, Nipun
On 11-04-2025 10:47, Herbert Xu wrote: On Fri, Apr 11, 2025 at 10:21:03AM +0530, Gupta, Nipun wrote: added crypto maintainers for comments. IMO, as accel framework is designed to support any type of compute accelerators, the PKI crypto accelerator in accel framework is not completely out of

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-11 Thread Jeff Hugo
On 4/9/2025 11:30 AM, Nipun Gupta wrote: The AMD PKI accelerator driver provides a accel interface to interact "an accel" with the device for offloading and accelerating asymmetric crypto operations. Signed-off-by: Nipun Gupta --- Changes RFC->v2: - moved from misc to accel - added archite

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-10 Thread Herbert Xu
On Fri, Apr 11, 2025 at 10:21:03AM +0530, Gupta, Nipun wrote: > > added crypto maintainers for comments. > IMO, as accel framework is designed to support any type of compute > accelerators, the PKI crypto accelerator in accel framework is not > completely out of place here, as also suggested at: >

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-10 Thread Gupta, Nipun
On 10-04-2025 13:06, Krzysztof Kozlowski wrote: On Wed, Apr 09, 2025 at 11:00:32PM GMT, Nipun Gupta wrote: The AMD PKI accelerator driver provides a accel interface to interact with the device for offloading and accelerating asymmetric crypto operations. For me this is clearly a crypto dri

Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-10 Thread Krzysztof Kozlowski
On Wed, Apr 09, 2025 at 11:00:32PM GMT, Nipun Gupta wrote: > The AMD PKI accelerator driver provides a accel interface to interact > with the device for offloading and accelerating asymmetric crypto > operations. > For me this is clearly a crypto driver and you are supposed to: 1. Cc crypto maint

[PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator

2025-04-09 Thread Nipun Gupta
The AMD PKI accelerator driver provides a accel interface to interact with the device for offloading and accelerating asymmetric crypto operations. Signed-off-by: Nipun Gupta --- Changes RFC->v2: - moved from misc to accel - added architecture and compile test dependency in Kconfig - removed sys