Re: [PATCH v2 2/2] rust: drm: Add GPUVM abstraction

2025-05-14 Thread Daniel Almeida
> > The lock might be held already by the driver or by TTM when things are called > from TTM callbacks. > > This is why GPUVM never takes locks by itself, but asserts that the correct > lock > is held. > > I think we really want to get proof by the driver by providing lock guard > references.

Re: [PATCH v2 2/2] rust: drm: Add GPUVM abstraction

2025-04-23 Thread Danilo Krummrich
On Wed, Apr 23, 2025 at 10:29:01AM -0300, Daniel Almeida wrote: > Hi Danilo, > > FYI, most of this patch still retains the original code from the Asahi > project, > > > On 22 Apr 2025, at 18:16, Danilo Krummrich wrote: > > > > (Not a full review, but some things that took my attention from a b

Re: [PATCH v2 2/2] rust: drm: Add GPUVM abstraction

2025-04-23 Thread Daniel Almeida
Hi Danilo, FYI, most of this patch still retains the original code from the Asahi project, > On 22 Apr 2025, at 18:16, Danilo Krummrich wrote: > > (Not a full review, but some things that took my attention from a brief look.) > > On Tue, Apr 22, 2025 at 01:41:53PM -0300, Daniel Almeida wrote:

Re: [PATCH v2 2/2] rust: drm: Add GPUVM abstraction

2025-04-22 Thread Danilo Krummrich
(Not a full review, but some things that took my attention from a brief look.) On Tue, Apr 22, 2025 at 01:41:53PM -0300, Daniel Almeida wrote: > diff --git a/rust/helpers/drm_gpuvm.c b/rust/helpers/drm_gpuvm.c > new file mode 100644 > index > ..7a074d2c2160

[PATCH v2 2/2] rust: drm: Add GPUVM abstraction

2025-04-22 Thread Daniel Almeida
From: Asahi Lina Add a GPUVM abstraction to be used by Rust GPU drivers. GPUVM keeps track of a GPU's virtual address (VA) space and manages the corresponding virtual mappings represented by "GPU VA" objects. It also keeps track of the mapping's backing GEM buffers. This initial version only su