Re: [PATCH v2 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-16 Thread AngeloGioacchino Del Regno
Il 16/05/23 11:30, Julien Stephan ha scritto: On Mon, May 15, 2023 at 04:32:42PM +0200, AngeloGioacchino Del Regno wrote: Il 15/05/23 16:07, Julien Stephan ha scritto: On Mon, May 15, 2023 at 02:22:52PM +0200, AngeloGioacchino Del Regno wrote: +#define CSIxB_OFFSET 0x1000 What if w

Re: [PATCH v2 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-16 Thread Julien Stephan
On Mon, May 15, 2023 at 04:32:42PM +0200, AngeloGioacchino Del Regno wrote: > Il 15/05/23 16:07, Julien Stephan ha scritto: > > On Mon, May 15, 2023 at 02:22:52PM +0200, AngeloGioacchino Del Regno wrote: > > > > +#define CSIxB_OFFSET 0x1000 > > > > > > What if we grab two (or three?) iosp

Re: [PATCH v2 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-15 Thread Julien Stephan
On Mon, May 15, 2023 at 04:22:38PM +0200, AngeloGioacchino Del Regno wrote: > Il 15/05/23 15:36, Julien Stephan ha scritto: > > On Mon, May 15, 2023 at 02:22:52PM +0200, AngeloGioacchino Del Regno wrote: > > > Il 15/05/23 11:05, Julien Stephan ha scritto: > > ..snip.. > > > > + port->is_cdp

Re: [PATCH v2 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-15 Thread AngeloGioacchino Del Regno
Il 15/05/23 16:07, Julien Stephan ha scritto: On Mon, May 15, 2023 at 02:22:52PM +0200, AngeloGioacchino Del Regno wrote: +#define CSIxB_OFFSET 0x1000 What if we grab two (or three?) iospaces from devicetree? - base (global) - csi_a - csi_b That would make it possible to maybe even

Re: [PATCH v2 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-15 Thread AngeloGioacchino Del Regno
Il 15/05/23 15:36, Julien Stephan ha scritto: On Mon, May 15, 2023 at 02:22:52PM +0200, AngeloGioacchino Del Regno wrote: Il 15/05/23 11:05, Julien Stephan ha scritto: ..snip.. + port->is_cdphy = of_property_read_bool(dev->of_node, "mediatek,is_cdphy"); This driver doesn't support C

Re: [PATCH v2 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-15 Thread Julien Stephan
On Mon, May 15, 2023 at 02:22:52PM +0200, AngeloGioacchino Del Regno wrote: > > +#define CSIxB_OFFSET 0x1000 > > What if we grab two (or three?) iospaces from devicetree? > > - base (global) > - csi_a > - csi_b > > That would make it possible to maybe eventually extend this driver to

Re: [PATCH v2 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-15 Thread Julien Stephan
On Mon, May 15, 2023 at 02:22:52PM +0200, AngeloGioacchino Del Regno wrote: > Il 15/05/23 11:05, Julien Stephan ha scritto: ..snip.. > > + port->is_cdphy = of_property_read_bool(dev->of_node, > > "mediatek,is_cdphy"); > > This driver doesn't support C-PHY mode, so you either add support for tha

Re: [PATCH v2 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-15 Thread AngeloGioacchino Del Regno
Il 15/05/23 11:05, Julien Stephan ha scritto: From: Phi-bang Nguyen This is a new driver that supports the MIPI CSI CD-PHY version 0.5 The number of PHYs depend on the soc. Signed-off-by: Louis Kuo Signed-off-by: Phi-bang Nguyen [Julien Stephan: use GENMASK] [Julien Stephan: refactor code]

[PATCH v2 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-15 Thread Julien Stephan
From: Phi-bang Nguyen This is a new driver that supports the MIPI CSI CD-PHY version 0.5 The number of PHYs depend on the soc. Signed-off-by: Louis Kuo Signed-off-by: Phi-bang Nguyen [Julien Stephan: use GENMASK] [Julien Stephan: refactor code] [Julien Stephan: update device tree support and