Re: [PATCH v2 2/2] drm/dp_mst: Add helper to get port number at specific LCT from RAD

2025-01-09 Thread Lyude Paul
Patch looks good to me, just one small change: On Mon, 2024-12-23 at 12:07 +0800, Wayne Lin wrote: > - for (i = 0; i < lct - 1; i++) { > - int shift = (i % 2) ? 0 : 4; > - int port_num = (rad[i / 2] >> shift) & 0xf; > + for (i = 1; i < lct; i++) { > + in

[PATCH v2 2/2] drm/dp_mst: Add helper to get port number at specific LCT from RAD

2024-12-22 Thread Wayne Lin
Add a helper drm_dp_mst_get_ufp_num_at_lct_from_rad() to extract the up facing port number at specific link count from the RAD. Use the added helper in drm_dp_mst_rad_to_str() & drm_dp_get_mst_branch_device() to unify the implementation. Cc: Imre Deak Cc: Ville Syrjälä Cc: Harry Wentland Cc: Ly