Re: [alsa-devel] [PATCH v2 2/2] drm/bridge: adv7511: restrict audio sample sizes

2017-08-01 Thread Arnaud Pouliquen
Hello Srinivas, On 08/01/2017 12:49 AM, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > ADV7533 only supports audio samples word width from 16-24 bits. > This patch restricts the audio sample sizes to the supported ones, > so that sound card does not report wrong list of su

Re: [alsa-devel] [PATCH v2 2/2] drm/bridge: adv7511: restrict audio sample sizes

2017-08-01 Thread Arnaud Pouliquen
Hello Srinivas, On 08/01/2017 02:52 PM, Srinivas Kandagatla wrote: As example, if you configure bus in Left justified format with 24 bits sample length, 32 bits application samples should be truncated to 24 bits samples at ADV7533 I2S interface level (LSB dropped). >> >>> May be we

Re: [alsa-devel] [PATCH v2 2/2] drm/bridge: adv7511: restrict audio sample sizes

2017-08-01 Thread Mark Brown
On Tue, Aug 01, 2017 at 01:52:35PM +0100, Srinivas Kandagatla wrote: > On 01/08/17 13:28, Mark Brown wrote: > > > And it's a false indication that we are supporting 32bit samples. > > > Which am not very happy with. > > This is what the sample_bits field in the DAI structure is for.ya. > But sti

Re: [alsa-devel] [PATCH v2 2/2] drm/bridge: adv7511: restrict audio sample sizes

2017-08-01 Thread Srinivas Kandagatla
On 01/08/17 13:28, Mark Brown wrote: On Tue, Aug 01, 2017 at 01:24:03PM +0100, Srinivas Kandagatla wrote: On 01/08/17 09:42, Arnaud Pouliquen wrote: On 08/01/2017 12:49 AM, srinivas.kandaga...@linaro.org wrote: I already used ADV7513 and i did not observe this limitation. I had a look t

Re: [alsa-devel] [PATCH v2 2/2] drm/bridge: adv7511: restrict audio sample sizes

2017-08-01 Thread Mark Brown
On Tue, Aug 01, 2017 at 01:24:03PM +0100, Srinivas Kandagatla wrote: > On 01/08/17 09:42, Arnaud Pouliquen wrote: > > On 08/01/2017 12:49 AM, srinivas.kandaga...@linaro.org wrote: > > I already used ADV7513 and i did not observe this limitation. > > I had a look to ADV7533 data-sheet. it should s

Re: [alsa-devel] [PATCH v2 2/2] drm/bridge: adv7511: restrict audio sample sizes

2017-08-01 Thread Srinivas Kandagatla
On 01/08/17 09:42, Arnaud Pouliquen wrote: Hello Srinivas, On 08/01/2017 12:49 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla ADV7533 only supports audio samples word width from 16-24 bits. This patch restricts the audio sample sizes to the supported ones, so that sound

[PATCH v2 2/2] drm/bridge: adv7511: restrict audio sample sizes

2017-07-31 Thread srinivas . kandagatla
From: Srinivas Kandagatla ADV7533 only supports audio samples word width from 16-24 bits. This patch restricts the audio sample sizes to the supported ones, so that sound card does not report wrong list of supported hwparms. Without this patch aplay would fail when playing a 32 bit audio. Signe