Re: [PATCH v2 2/2] drm/auth: make drm_{set,drop]master_ioctl symmetrical

2020-05-30 Thread Sam Ravnborg
On Sat, May 30, 2020 at 02:34:10PM +0100, Emil Velikov wrote: > On Sat, 30 May 2020 at 14:18, Sam Ravnborg wrote: > > > > Hi Emil. > > On Sat, May 30, 2020 at 01:46:40PM +0100, Emil Velikov wrote: > > > Currently the ret handling is all over the place - with two redundant > > > assignments and ano

Re: [PATCH v2 2/2] drm/auth: make drm_{set, drop]master_ioctl symmetrical

2020-05-30 Thread Emil Velikov
On Sat, 30 May 2020 at 14:18, Sam Ravnborg wrote: > > Hi Emil. > On Sat, May 30, 2020 at 01:46:40PM +0100, Emil Velikov wrote: > > Currently the ret handling is all over the place - with two redundant > > assignments and another one addressed earlier. > > > > Use the exact same flow in both functi

Re: [PATCH v2 2/2] drm/auth: make drm_{set,drop]master_ioctl symmetrical

2020-05-30 Thread Sam Ravnborg
Hi Emil. On Sat, May 30, 2020 at 01:46:40PM +0100, Emil Velikov wrote: > Currently the ret handling is all over the place - with two redundant > assignments and another one addressed earlier. > > Use the exact same flow in both functions. > > v2: straighten the code flow, instead of just removing

[PATCH v2 2/2] drm/auth: make drm_{set,drop]master_ioctl symmetrical

2020-05-30 Thread Emil Velikov
Currently the ret handling is all over the place - with two redundant assignments and another one addressed earlier. Use the exact same flow in both functions. v2: straighten the code flow, instead of just removing the assignments Cc: David Airlie Cc: Daniel Vetter Cc: Sam Ravnborg Cc: Colin