Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-05-21 Thread Maxime Ripard
Hi Jared, On Thu, Apr 24, 2025 at 09:11:24AM -0700, Jared Kangas wrote: > > > struct cma_heap { > > > struct dma_heap *heap; > > > @@ -394,15 +395,26 @@ static int __init __add_cma_heap(struct cma *cma, > > > const char *name) > > > static int __init add_default_cma_heap(void) > > > { > > >

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-05-06 Thread Maxime Ripard
On Tue, Apr 29, 2025 at 09:25:00AM -0700, John Stultz wrote: > On Mon, Apr 28, 2025 at 7:52 AM Maxime Ripard wrote: > > On Fri, Apr 25, 2025 at 12:39:40PM -0700, John Stultz wrote: > > > To your larger point about policy, I do get the tension that you want > > > to be able to programmatically deri

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-29 Thread John Stultz
On Mon, Apr 28, 2025 at 7:52 AM Maxime Ripard wrote: > On Fri, Apr 25, 2025 at 12:39:40PM -0700, John Stultz wrote: > > To your larger point about policy, I do get the tension that you want > > to be able to programmatically derive or evaluate heap names, so that > > applications can consistently

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-28 Thread Maxime Ripard
Hi John, On Fri, Apr 25, 2025 at 12:39:40PM -0700, John Stultz wrote: > On Thu, Apr 24, 2025 at 11:58 PM Maxime Ripard wrote: > > On Thu, Apr 24, 2025 at 05:13:47PM -0700, John Stultz wrote: > > > On Thu, Apr 24, 2025 at 1:34 AM Maxime Ripard wrote: > > > > I appreciate this is kind of bikeshed-

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-25 Thread John Stultz
On Thu, Apr 24, 2025 at 11:58 PM Maxime Ripard wrote: > On Thu, Apr 24, 2025 at 05:13:47PM -0700, John Stultz wrote: > > On Thu, Apr 24, 2025 at 1:34 AM Maxime Ripard wrote: > > > I appreciate this is kind of bikeshed-color territory, but I think "cma" > > > would be a better option here. There's

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-25 Thread Maxime Ripard
On Thu, Apr 24, 2025 at 05:13:47PM -0700, John Stultz wrote: > On Thu, Apr 24, 2025 at 1:34 AM Maxime Ripard wrote: > > On Tue, Apr 22, 2025 at 12:19:39PM -0700, Jared Kangas wrote: > > > @@ -22,6 +22,7 @@ > > > #include > > > #include > > > > > > +#define DEFAULT_CMA_NAME "default_cma" > > >

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-24 Thread John Stultz
On Thu, Apr 24, 2025 at 1:34 AM Maxime Ripard wrote: > On Tue, Apr 22, 2025 at 12:19:39PM -0700, Jared Kangas wrote: > > @@ -22,6 +22,7 @@ > > #include > > #include > > > > +#define DEFAULT_CMA_NAME "default_cma" > > I appreciate this is kind of bikeshed-color territory, but I think "cma" > wo

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-24 Thread Jared Kangas
Hi Maxime, On Thu, Apr 24, 2025 at 10:33:58AM +0200, Maxime Ripard wrote: > Hi Jared, > > Thanks for working on this > > On Tue, Apr 22, 2025 at 12:19:39PM -0700, Jared Kangas wrote: > > The CMA heap's name in devtmpfs can vary depending on how the heap is > > defined. Its name defaults to "rese

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-24 Thread Maxime Ripard
Hi Jared, Thanks for working on this On Tue, Apr 22, 2025 at 12:19:39PM -0700, Jared Kangas wrote: > The CMA heap's name in devtmpfs can vary depending on how the heap is > defined. Its name defaults to "reserved", but if a CMA area is defined > in the devicetree, the heap takes on the devicetree

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-22 Thread John Stultz
On Tue, Apr 22, 2025 at 12:19 PM Jared Kangas wrote: > > The CMA heap's name in devtmpfs can vary depending on how the heap is > defined. Its name defaults to "reserved", but if a CMA area is defined > in the devicetree, the heap takes on the devicetree node's name, such as > "default-pool" or "li

[PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-22 Thread Jared Kangas
The CMA heap's name in devtmpfs can vary depending on how the heap is defined. Its name defaults to "reserved", but if a CMA area is defined in the devicetree, the heap takes on the devicetree node's name, such as "default-pool" or "linux,cma". To simplify naming, just name it "default_cma", and ke