Re: [PATCH v2 2/2] backlight: Add Kinetic KTD2801 driver

2024-01-19 Thread Duje Mihanović
On Friday, January 19, 2024 6:29:21 PM CET Christophe JAILLET wrote: > Le 18/01/2024 à 18:32, Duje Mihanović a écrit : > > Add driver for the Kinetic KTD2801 backlight driver. > > > > Signed-off-by: Duje Mihanović > > > > --- > > ... > > > + ktd2801->gpiod = devm_gpiod_get(dev, "ctrl", GPIOD

Re: [PATCH v2 2/2] backlight: Add Kinetic KTD2801 driver

2024-01-19 Thread Christophe JAILLET
Le 18/01/2024 à 18:32, Duje Mihanović a écrit : Add driver for the Kinetic KTD2801 backlight driver. Signed-off-by: Duje Mihanović --- ... + ktd2801->gpiod = devm_gpiod_get(dev, "ctrl", GPIOD_OUT_HIGH); + if (IS_ERR(ktd2801->gpiod)) + return dev_err_probe(dev, PTR

Re: [PATCH v2 2/2] backlight: Add Kinetic KTD2801 driver

2024-01-19 Thread Duje Mihanović
On Friday, January 19, 2024 11:07:09 AM CET Daniel Thompson wrote: > On Thu, Jan 18, 2024 at 06:32:39PM +0100, Duje Mihanović wrote: > > Add driver for the Kinetic KTD2801 backlight driver. > > > > Signed-off-by: Duje Mihanović > > > > --- > > Shared ExpressWire handling code and preemption watc

Re: [PATCH v2 2/2] backlight: Add Kinetic KTD2801 driver

2024-01-19 Thread Duje Mihanović
On Friday, January 19, 2024 10:02:33 AM CET Linus Walleij wrote: > Hi Duje, > > thanks for your patch! > > On Thu, Jan 18, 2024 at 6:33 PM Duje Mihanović wrote: > > Add driver for the Kinetic KTD2801 backlight driver.> > > Signed-off-by: Duje Mihanović > > Add some commit message? Besides th

Re: [PATCH v2 2/2] backlight: Add Kinetic KTD2801 driver

2024-01-19 Thread Daniel Thompson
On Thu, Jan 18, 2024 at 06:32:39PM +0100, Duje Mihanović wrote: > Add driver for the Kinetic KTD2801 backlight driver. > > Signed-off-by: Duje Mihanović > > --- > Shared ExpressWire handling code and preemption watchdogs haven't been > implemented in this version as my questions regarding these tw

Re: [PATCH v2 2/2] backlight: Add Kinetic KTD2801 driver

2024-01-19 Thread Linus Walleij
Hi Duje, thanks for your patch! On Thu, Jan 18, 2024 at 6:33 PM Duje Mihanović wrote: > Add driver for the Kinetic KTD2801 backlight driver.> > Signed-off-by: Duje Mihanović Add some commit message? > +#include > +#include > +#include > +#include I don't think you need , the compatible

[PATCH v2 2/2] backlight: Add Kinetic KTD2801 driver

2024-01-18 Thread Duje Mihanović
Add driver for the Kinetic KTD2801 backlight driver. Signed-off-by: Duje Mihanović --- Shared ExpressWire handling code and preemption watchdogs haven't been implemented in this version as my questions regarding these two weren't answered. --- MAINTAINERS | 6 +