Re: [PATCH v2 15/27] gpu: host1x: Add support for Tegra114

2013-10-15 Thread Thierry Reding
On Mon, Oct 14, 2013 at 08:30:28AM +0300, Terje Bergström wrote: > On 12.10.2013 14:24, Thierry Reding wrote: > > Yeah, I don't like very much how this is currently done. I mean about > > half of this is actually duplicate code because of the static inline > > functions used for register defines. A

Re: [PATCH v2 15/27] gpu: host1x: Add support for Tegra114

2013-10-15 Thread Thierry Reding
On Mon, Oct 14, 2013 at 12:07:33PM -0600, Stephen Warren wrote: > On 10/12/2013 05:24 AM, Thierry Reding wrote: > > On Fri, Oct 11, 2013 at 04:13:07PM -0600, Stephen Warren wrote: > >> On 10/07/2013 02:34 AM, Thierry Reding wrote: > >>> Tegra114 uses a slightly updated version of host1x with an > >

Re: [PATCH v2 15/27] gpu: host1x: Add support for Tegra114

2013-10-14 Thread Stephen Warren
On 10/12/2013 05:24 AM, Thierry Reding wrote: > On Fri, Oct 11, 2013 at 04:13:07PM -0600, Stephen Warren wrote: >> On 10/07/2013 02:34 AM, Thierry Reding wrote: >>> Tegra114 uses a slightly updated version of host1x with an >>> additional syncpoint. >> >>> drivers/gpu/host1x/hw/host1x02.c

Re: [PATCH v2 15/27] gpu: host1x: Add support for Tegra114

2013-10-13 Thread Terje Bergström
On 12.10.2013 14:24, Thierry Reding wrote: > Yeah, I don't like very much how this is currently done. I mean about > half of this is actually duplicate code because of the static inline > functions used for register defines. As discussed elsewhere this was > originally meant to be used for coverage

Re: [PATCH v2 15/27] gpu: host1x: Add support for Tegra114

2013-10-12 Thread Thierry Reding
On Fri, Oct 11, 2013 at 04:13:07PM -0600, Stephen Warren wrote: > On 10/07/2013 02:34 AM, Thierry Reding wrote: > > Tegra114 uses a slightly updated version of host1x with an additional > > syncpoint. > > > drivers/gpu/host1x/hw/host1x02.c| 42 + > > drivers/gpu/host1x/hw/host1x0

Re: [PATCH v2 15/27] gpu: host1x: Add support for Tegra114

2013-10-11 Thread Stephen Warren
On 10/07/2013 02:34 AM, Thierry Reding wrote: > Tegra114 uses a slightly updated version of host1x with an additional > syncpoint. > drivers/gpu/host1x/hw/host1x02.c| 42 + > drivers/gpu/host1x/hw/host1x02.h| 26 +++ > drivers/gpu/host1x/hw/hw_host1x02_channel.h | 12

[PATCH v2 15/27] gpu: host1x: Add support for Tegra114

2013-10-07 Thread Thierry Reding
Tegra114 uses a slightly updated version of host1x with an additional syncpoint. Signed-off-by: Thierry Reding --- Changes in v2: - fix register fields changed from host1x01 drivers/gpu/host1x/Makefile | 3 +- drivers/gpu/host1x/dev.c| 11 ++ drivers/gpu/h