Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-09-07 Thread Maxime Ripard
Hi, On Tue, Aug 30, 2022 at 04:36:23PM +0300, Jani Nikula wrote: > On Tue, 30 Aug 2022, Maxime Ripard wrote: > > Hi, > > > > On Tue, Aug 30, 2022 at 01:43:07PM +0300, Jani Nikula wrote: > >> On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > >> > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrot

Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-08-30 Thread Jani Nikula
On Tue, 30 Aug 2022, Maxime Ripard wrote: > Hi, > > On Tue, Aug 30, 2022 at 01:43:07PM +0300, Jani Nikula wrote: >> On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: >> > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: >> >> +#define STR_STRICT_EQ(str, len, cmp) \ >> >> + ((strlen(cmp) =

Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-08-30 Thread Maxime Ripard
Hi, On Tue, Aug 30, 2022 at 01:43:07PM +0300, Jani Nikula wrote: > On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: > >> +#define STR_STRICT_EQ(str, len, cmp) \ > >> + ((strlen(cmp) == len) && !strncmp(str, cmp, len)) > > > > This is n

Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-08-30 Thread Jani Nikula
On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: >> +#define STR_STRICT_EQ(str, len, cmp) \ >> + ((strlen(cmp) == len) && !strncmp(str, cmp, len)) > > This is not part of the move, but newly added. The same construct is also duplicated e

Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-08-30 Thread Geert Uytterhoeven
Hi Maxime, On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: > The current construction of the named mode parsing doesn't allow to extend > it easily. Let's move it to a separate function so we can add more > parameters and modes. > > Signed-off-by: Maxime Ripard Thanks for your patch! > --

[PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-08-29 Thread Maxime Ripard
The current construction of the named mode parsing doesn't allow to extend it easily. Let's move it to a separate function so we can add more parameters and modes. Signed-off-by: Maxime Ripard diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 99a21e5cd00d..0636cb707544