Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

On Tue, 01 Dec 2020, Daniel Vetter wrote: > On Tue, Dec 1, 2020 at 10:46 AM Lee Jones wrote: > > > > On Tue, 01 Dec 2020, Sam Ravnborg wrote: > > > > > Hi Lee, > > > > > > > > > > > Cop-out! > > > > > > > > Do what I do and make something up (joke)! :'D > > > > > > If I thought anyone would actua

Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

On Tue, Dec 1, 2020 at 10:46 AM Lee Jones wrote: > > On Tue, 01 Dec 2020, Sam Ravnborg wrote: > > > Hi Lee, > > > > > > > > Cop-out! > > > > > > Do what I do and make something up (joke)! :'D > > > > If I thought anyone would actually read the comments then maybe yes. > > But I assume that apart f

Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

On Tue, 01 Dec 2020, Sam Ravnborg wrote: > Hi Lee, > > > > > Cop-out! > > > > Do what I do and make something up (joke)! :'D > > If I thought anyone would actually read the comments then maybe yes. > But I assume that apart from this thread no-one will read it. > > > > > > > Well, it fixes t

Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

Hi Lee, > > Cop-out! > > Do what I do and make something up (joke)! :'D If I thought anyone would actually read the comments then maybe yes. But I assume that apart from this thread no-one will read it. > > > > Well, it fixes the warning ;) > > > > Yeah, I could not dig up anything useful to

Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

On Mon, 30 Nov 2020, Sam Ravnborg wrote: > On Mon, Nov 30, 2020 at 01:14:52PM +0100, Thomas Zimmermann wrote: > > > > > > Am 28.11.20 um 23:40 schrieb Sam Ravnborg: > > > Fix W=1 warnings: > > > - Fix kernel-doc > > > - Drop unused variables/code > > > > > > v2: > > >- Updated subject (Lee)

Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

On Mon, Nov 30, 2020 at 01:14:52PM +0100, Thomas Zimmermann wrote: > > > Am 28.11.20 um 23:40 schrieb Sam Ravnborg: > > Fix W=1 warnings: > > - Fix kernel-doc > > - Drop unused variables/code > > > > v2: > >- Updated subject (Lee) > > > > Signed-off-by: Sam Ravnborg > > Cc: Antonino Daplas

Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

Am 28.11.20 um 23:40 schrieb Sam Ravnborg: Fix W=1 warnings: - Fix kernel-doc - Drop unused variables/code v2: - Updated subject (Lee) Signed-off-by: Sam Ravnborg Cc: Antonino Daplas Cc: linux-fb...@vger.kernel.org Cc: Lee Jones --- drivers/video/fbdev/riva/fbdev.c | 9 -

[PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

Fix W=1 warnings: - Fix kernel-doc - Drop unused variables/code v2: - Updated subject (Lee) Signed-off-by: Sam Ravnborg Cc: Antonino Daplas Cc: linux-fb...@vger.kernel.org Cc: Lee Jones --- drivers/video/fbdev/riva/fbdev.c | 9 - drivers/video/fbdev/riva/riva_hw.c | 28 --