Re: [PATCH v2 13/16] drm/vmwgfx: Port the framebuffer code to drm fb helpers

2022-10-21 Thread Thomas Zimmermann
Hi Am 20.10.22 um 20:37 schrieb Zack Rusin: On Thu, 2022-10-20 at 11:06 +0200, Thomas Zimmermann wrote: Hi Zack Am 20.10.22 um 05:41 schrieb Zack Rusin: From: Zack Rusin [...] @@ -1670,6 +1640,10 @@ static int vmw_probe(struct pci_dev *pdev, const struct pci_device_id *ent) if (re

Re: [PATCH v2 13/16] drm/vmwgfx: Port the framebuffer code to drm fb helpers

2022-10-20 Thread Zack Rusin
On Thu, 2022-10-20 at 11:06 +0200, Thomas Zimmermann wrote: > Hi Zack > > Am 20.10.22 um 05:41 schrieb Zack Rusin: > > From: Zack Rusin > [...] > > @@ -1670,6 +1640,10 @@ static int vmw_probe(struct pci_dev *pdev, const > > struct pci_device_id *ent) > > if (ret) > > goto out_unl

Re: [PATCH v2 13/16] drm/vmwgfx: Port the framebuffer code to drm fb helpers

2022-10-20 Thread Thomas Zimmermann
Hi Zack Am 20.10.22 um 05:41 schrieb Zack Rusin: From: Zack Rusin [...] @@ -1670,6 +1640,10 @@ static int vmw_probe(struct pci_dev *pdev, const struct pci_device_id *ent) if (ret) goto out_unload; + vmw_fifo_resource_inc(vmw); + vmw_svga_enable(vmw); +

[PATCH v2 13/16] drm/vmwgfx: Port the framebuffer code to drm fb helpers

2022-10-19 Thread Zack Rusin
From: Zack Rusin Instead of using vmwgfx specific framebuffer implementation use the drm fb helpers. There's no change in functionality, the only difference is a reduction in the amount of code inside the vmwgfx module. drm fb helpers do not deal correctly with changes in crtc preferred mode at