Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-02-10 Thread Hans de Goede
Hi, On 30-01-17 16:11, Ville Syrjälä wrote: On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: Hi, On 30-01-17 14:10, Ville Syrjälä wrote: On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: Hi, On 01/28/2017 05:25 PM, Hans de Goede wrote: Hi, On 01/27/2017 02:51 PM

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Hans de Goede
Hi, On 30-01-17 16:38, Ville Syrjälä wrote: On Mon, Jan 30, 2017 at 04:27:58PM +0100, Hans de Goede wrote: Hi, On 30-01-17 16:11, Ville Syrjälä wrote: On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: Hi, On 30-01-17 14:10, Ville Syrjälä wrote: On Sat, Jan 28, 2017 at 06:18:45

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Ville Syrjälä
On Mon, Jan 30, 2017 at 04:27:58PM +0100, Hans de Goede wrote: > Hi, > > On 30-01-17 16:11, Ville Syrjälä wrote: > > On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 30-01-17 14:10, Ville Syrjälä wrote: > >>> On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goe

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Hans de Goede
Hi, On 30-01-17 16:11, Ville Syrjälä wrote: On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: Hi, On 30-01-17 14:10, Ville Syrjälä wrote: On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: Hi, On 01/28/2017 05:25 PM, Hans de Goede wrote: Hi, On 01/27/2017 02:51 PM

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Ville Syrjälä
On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: > Hi, > > On 30-01-17 14:10, Ville Syrjälä wrote: > > On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 01/28/2017 05:25 PM, Hans de Goede wrote: > >>> Hi, > >>> > >>> On 01/27/2017 02:51 PM, Ville Sy

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Hans de Goede
Hi, On 30-01-17 14:10, Ville Syrjälä wrote: On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: Hi, On 01/28/2017 05:25 PM, Hans de Goede wrote: Hi, On 01/27/2017 02:51 PM, Ville Syrjälä wrote: On Mon, Jan 23, 2017 at 10:09:58PM +0100, Hans de Goede wrote: Make sure the P-Unit o

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Ville Syrjälä
On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: > Hi, > > On 01/28/2017 05:25 PM, Hans de Goede wrote: > > Hi, > > > > On 01/27/2017 02:51 PM, Ville Syrjälä wrote: > >> On Mon, Jan 23, 2017 at 10:09:58PM +0100, Hans de Goede wrote: > >>> Make sure the P-Unit or the PMIC i2c bus is n

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-28 Thread Hans de Goede
Hi, On 01/28/2017 05:25 PM, Hans de Goede wrote: Hi, On 01/27/2017 02:51 PM, Ville Syrjälä wrote: On Mon, Jan 23, 2017 at 10:09:58PM +0100, Hans de Goede wrote: Make sure the P-Unit or the PMIC i2c bus is not in use when we send a request to the P-Unit by calling iosf_mbi_punit_acquire() / _r

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-28 Thread Hans de Goede
Hi, On 01/27/2017 02:51 PM, Ville Syrjälä wrote: On Mon, Jan 23, 2017 at 10:09:58PM +0100, Hans de Goede wrote: Make sure the P-Unit or the PMIC i2c bus is not in use when we send a request to the P-Unit by calling iosf_mbi_punit_acquire() / _release() around P-Unit write accesses. Can't we j

Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-27 Thread Ville Syrjälä
On Mon, Jan 23, 2017 at 10:09:58PM +0100, Hans de Goede wrote: > Make sure the P-Unit or the PMIC i2c bus is not in use when we send a > request to the P-Unit by calling iosf_mbi_punit_acquire() / _release() > around P-Unit write accesses. Can't we just stuff the calls into the actual punit write

[PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-23 Thread Hans de Goede
Make sure the P-Unit or the PMIC i2c bus is not in use when we send a request to the P-Unit by calling iosf_mbi_punit_acquire() / _release() around P-Unit write accesses. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=155241 Signed-off-by: Hans de Goede Tested-by: tagorereddy --- Changes i