Re: [PATCH v2 10/17] drm/i915/vm_bind: Abstract out common execbuf functions

2022-10-03 Thread Andi Shyti
Hi Niranjana, On Mon, Oct 03, 2022 at 02:06:18PM -0700, Niranjana Vishwanathapura wrote: > On Mon, Oct 03, 2022 at 05:53:37PM +0200, Andi Shyti wrote: > > Hi Niranjana, > > > > [...] > > > > > + for_each_child(ce, child) { > > > + err = intel_context_pin_ww(child, ww); > > > + GE

Re: [PATCH v2 10/17] drm/i915/vm_bind: Abstract out common execbuf functions

2022-10-03 Thread Niranjana Vishwanathapura
On Mon, Oct 03, 2022 at 05:53:37PM +0200, Andi Shyti wrote: Hi Niranjana, [...] + for_each_child(ce, child) { + err = intel_context_pin_ww(child, ww); + GEM_BUG_ON(err);/* perma-pinned should incr a counter */ + } + + for_each_child(ce, chi

Re: [PATCH v2 10/17] drm/i915/vm_bind: Abstract out common execbuf functions

2022-10-03 Thread Andi Shyti
Hi Niranjana, [...] > + for_each_child(ce, child) { > + err = intel_context_pin_ww(child, ww); > + GEM_BUG_ON(err);/* perma-pinned should incr a counter */ > + } > + > + for_each_child(ce, child) { > + err = eb_pin_timeline(child, throttle,

[PATCH v2 10/17] drm/i915/vm_bind: Abstract out common execbuf functions

2022-10-02 Thread Niranjana Vishwanathapura
The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Abstract out the common execbuf functionalities into a separate file where possible, thus allowing code sharing. Acked-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i