Re: [PATCH v2 1/8] mm: slab: provide krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
On Mon, Nov 2, 2020 at 4:41 PM Matthew Wilcox wrote: > > On Mon, Nov 02, 2020 at 04:20:30PM +0100, Bartosz Golaszewski wrote: > > +Chunks allocated with `kmalloc` can be resized with `krealloc`. Similarly > > +to `kmalloc_array`: a helper for resising arrays is provided in the form of > > +`kreall

Re: [PATCH v2 1/8] mm: slab: provide krealloc_array()

2020-11-03 Thread Matthew Wilcox
On Mon, Nov 02, 2020 at 04:20:30PM +0100, Bartosz Golaszewski wrote: > +Chunks allocated with `kmalloc` can be resized with `krealloc`. Similarly > +to `kmalloc_array`: a helper for resising arrays is provided in the form of > +`krealloc_array`. Is there any reason you chose to `do_this` instead o

[PATCH v2 1/8] mm: slab: provide krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
From: Bartosz Golaszewski When allocating an array of elements, users should check for multiplication overflow or preferably use one of the provided helpers like: kmalloc_array(). There's no krealloc_array() counterpart but there are many users who use regular krealloc() to reallocate arrays. Le