On 27/11/2024 00:34, Sasha Finkelstein via B4 Relay wrote:
[...]
> diff --git
> a/Documentation/devicetree/bindings/display/apple,h7-display-pipe-mipi.yaml
> b/Documentation/devicetree/bindings/display/apple,h7-display-pipe-mipi.yaml
> new file mode 100644
> index
> 0
On Tue, 26 Nov 2024 at 17:46, Krzysztof Kozlowski wrote:
> Please take a look how other bindings define ports. You miss here
> several items and more important - description what are these ports for.
Aside from missing descriptions, this definition is copied almost verbatim from
snps,dw-mipi-dsi.
On Tue, 26 Nov 2024 at 17:46, Krzysztof Kozlowski wrote:
> > +allOf:
> > + - $ref: dsi-controller.yaml#
...
> > +patternProperties:
> > + "^panel@[0-3]$": true
>
> These look unusual. Is this a DSI controller? If so, then reference
> dsi-controller. See other bindings how this is done.
This is
On 2024/11/27 2:20, Krzysztof Kozlowski wrote:
> On 26/11/2024 18:00, Sasha Finkelstein wrote:
>> On Tue, 26 Nov 2024 at 17:46, Krzysztof Kozlowski wrote:
+properties:
+ compatible:
+items:
+ - enum:
+ - apple,j293-summit
+ - apple,j493-
On 26/11/2024 18:00, Sasha Finkelstein wrote:
> On Tue, 26 Nov 2024 at 17:46, Krzysztof Kozlowski wrote:
>>> +allOf:
>>> + - $ref: dsi-controller.yaml#
> ...
>>> +patternProperties:
>>> + "^panel@[0-3]$": true
>>
>> These look unusual. Is this a DSI controller? If so, then reference
>> dsi-contr
On 26/11/2024 17:46, Krzysztof Kozlowski wrote:
>
>> +
>> + reg:
>> +maxItems: 1
>> +
>> + max-brightness: true
>> +
>> + port: true
>
> No, these cannot be true without definition. Again, please open existing
> bindings and use them as example. You probably miss here some reference,
> but
On 26/11/2024 17:34, Sasha Finkelstein via B4 Relay wrote:
> From: Sasha Finkelstein
>
> Add bindings for a secondary display controller present on certain
> Apple laptops.
>
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindi
From: Sasha Finkelstein
Add bindings for a secondary display controller present on certain
Apple laptops.
Signed-off-by: Sasha Finkelstein
---
.../display/apple,h7-display-pipe-mipi.yaml| 89 ++
.../bindings/display/apple,h7-display-pipe.yaml| 77 +++
