Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-15 Thread Helen Koike
On 3/15/19 8:29 AM, Michel Dänzer wrote: > On 2019-03-15 11:25 a.m., Boris Brezillon wrote: >> On Fri, 15 Mar 2019 11:11:36 +0100 >> Michel Dänzer wrote: >> >>> On 2019-03-14 6:51 p.m., Helen Koike wrote: On 3/14/19 6:15 AM, Michel Dänzer wrote: > On 2019-03-13 7:08 p.m., Helen Koike

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-15 Thread Michel Dänzer
On 2019-03-15 11:25 a.m., Boris Brezillon wrote: > On Fri, 15 Mar 2019 11:11:36 +0100 > Michel Dänzer wrote: > >> On 2019-03-14 6:51 p.m., Helen Koike wrote: >>> On 3/14/19 6:15 AM, Michel Dänzer wrote: On 2019-03-13 7:08 p.m., Helen Koike wrote: > On 3/13/19 6:58 AM, Michel Dänzer w

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-15 Thread Boris Brezillon
On Fri, 15 Mar 2019 11:11:36 +0100 Michel Dänzer wrote: > On 2019-03-14 6:51 p.m., Helen Koike wrote: > > On 3/14/19 6:15 AM, Michel Dänzer wrote: > >> On 2019-03-13 7:08 p.m., Helen Koike wrote: > >>> On 3/13/19 6:58 AM, Michel Dänzer wrote: > On 2019-03-13 4:42 a.m., Tomasz Figa wrot

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-15 Thread Michel Dänzer
On 2019-03-14 6:51 p.m., Helen Koike wrote: > On 3/14/19 6:15 AM, Michel Dänzer wrote: >> On 2019-03-13 7:08 p.m., Helen Koike wrote: >>> On 3/13/19 6:58 AM, Michel Dänzer wrote: On 2019-03-13 4:42 a.m., Tomasz Figa wrote: > On Wed, Mar 13, 2019 at 12:52 AM Boris Brezillon > wrote: >>

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-14 Thread Helen Koike
On 3/14/19 6:15 AM, Michel Dänzer wrote: > On 2019-03-13 7:08 p.m., Helen Koike wrote: >> On 3/13/19 6:58 AM, Michel Dänzer wrote: >>> On 2019-03-13 4:42 a.m., Tomasz Figa wrote: On Wed, Mar 13, 2019 at 12:52 AM Boris Brezillon wrote: > On Tue, 12 Mar 2019 12:34:45 -0300 > Hele

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-14 Thread Michel Dänzer
On 2019-03-13 7:08 p.m., Helen Koike wrote: > On 3/13/19 6:58 AM, Michel Dänzer wrote: >> On 2019-03-13 4:42 a.m., Tomasz Figa wrote: >>> On Wed, Mar 13, 2019 at 12:52 AM Boris Brezillon >>> wrote: On Tue, 12 Mar 2019 12:34:45 -0300 Helen Koike wrote: > On 3/12/19 3:34 AM, Boris Bre

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-13 Thread Helen Koike
On 3/13/19 6:58 AM, Michel Dänzer wrote: > On 2019-03-13 4:42 a.m., Tomasz Figa wrote: >> On Wed, Mar 13, 2019 at 12:52 AM Boris Brezillon >> wrote: >>> >>> On Tue, 12 Mar 2019 12:34:45 -0300 >>> Helen Koike wrote: >>> On 3/12/19 3:34 AM, Boris Brezillon wrote: > On Mon, 11 Mar 2019 23

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-13 Thread Michel Dänzer
On 2019-03-13 4:42 a.m., Tomasz Figa wrote: > On Wed, Mar 13, 2019 at 12:52 AM Boris Brezillon > wrote: >> >> On Tue, 12 Mar 2019 12:34:45 -0300 >> Helen Koike wrote: >> >>> On 3/12/19 3:34 AM, Boris Brezillon wrote: On Mon, 11 Mar 2019 23:21:59 -0300 Helen Koike wrote: > In t

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-12 Thread Tomasz Figa
On Wed, Mar 13, 2019 at 12:52 AM Boris Brezillon wrote: > > On Tue, 12 Mar 2019 12:34:45 -0300 > Helen Koike wrote: > > > On 3/12/19 3:34 AM, Boris Brezillon wrote: > > > On Mon, 11 Mar 2019 23:21:59 -0300 > > > Helen Koike wrote: > > > > > >> In the case of async update, modifications are done

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-12 Thread Boris Brezillon
On Tue, 12 Mar 2019 12:34:45 -0300 Helen Koike wrote: > On 3/12/19 3:34 AM, Boris Brezillon wrote: > > On Mon, 11 Mar 2019 23:21:59 -0300 > > Helen Koike wrote: > > > >> In the case of async update, modifications are done in place, i.e. in the > >> current plane state, so the new_state is pre

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-12 Thread Helen Koike
On 3/12/19 3:34 AM, Boris Brezillon wrote: > On Mon, 11 Mar 2019 23:21:59 -0300 > Helen Koike wrote: > >> In the case of async update, modifications are done in place, i.e. in the >> current plane state, so the new_state is prepared and the new_state is >> cleanup up (instead of the old_state,

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-12 Thread Daniel Vetter
On Tue, Mar 12, 2019 at 07:34:38AM +0100, Boris Brezillon wrote: > On Mon, 11 Mar 2019 23:21:59 -0300 > Helen Koike wrote: > > > In the case of async update, modifications are done in place, i.e. in the > > current plane state, so the new_state is prepared and the new_state is > > cleanup up (ins

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-11 Thread Boris Brezillon
On Mon, 11 Mar 2019 23:21:59 -0300 Helen Koike wrote: > In the case of async update, modifications are done in place, i.e. in the > current plane state, so the new_state is prepared and the new_state is > cleanup up (instead of the old_state, diferrently on what happen in a ^ cleaned up

[PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-11 Thread Helen Koike
In the case of async update, modifications are done in place, i.e. in the current plane state, so the new_state is prepared and the new_state is cleanup up (instead of the old_state, diferrently on what happen in a normal sync update). To cleanup the old_fb properly, it needs to be placed in the ne