Re: [Intel-gfx] [PATCH v2 1/5] drm/i915/guc: Create the guc_to_i915() wrapper

2023-10-25 Thread Nirmoy Das
On 10/25/2023 4:53 PM, Andi Shyti wrote: Hi Nirmoy, +static inline struct drm_i915_private *guc_to_i915(struct intel_guc *guc) +{ + return guc_to_gt(guc)->i915; +} + We don't want inline functions in headers files[1]. Otherwise the series looks fine to me: the reason for that patch is

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915/guc: Create the guc_to_i915() wrapper

2023-10-25 Thread Andi Shyti
Hi Nirmoy, > > +static inline struct drm_i915_private *guc_to_i915(struct intel_guc *guc) > > +{ > > + return guc_to_gt(guc)->i915; > > +} > > + > > We don't want inline functions in headers files[1]. Otherwise the series > looks fine to me: the reason for that patch is that we were including

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915/guc: Create the guc_to_i915() wrapper

2023-10-25 Thread Nirmoy Das
Hi Andi, On 10/25/2023 4:35 PM, Andi Shyti wrote: Given a reference to "guc", the guc_to_i915() returns the pointer to "i915" private data. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt.h| 5 + drivers/gpu/drm/i915/gt/uc/intel_guc.c| 2 +-

[PATCH v2 1/5] drm/i915/guc: Create the guc_to_i915() wrapper

2023-10-25 Thread Andi Shyti
Given a reference to "guc", the guc_to_i915() returns the pointer to "i915" private data. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/intel_gt.h| 5 + drivers/gpu/drm/i915/gt/uc/intel_guc.c| 2 +- drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c| 2