RE: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-30 Thread Kasireddy, Vivek
Hi Bjorn, > Subject: Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for > functions of same device > > On Wed, Oct 30, 2024 at 03:20:02PM -0600, Logan Gunthorpe wrote: > > On 2024-10-30 12:46, Bjorn Helgaas wrote: > > > On Fri, Oct 25, 2024 at 06:57:37

Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-30 Thread Bjorn Helgaas
On Wed, Oct 30, 2024 at 03:20:02PM -0600, Logan Gunthorpe wrote: > On 2024-10-30 12:46, Bjorn Helgaas wrote: > > On Fri, Oct 25, 2024 at 06:57:37AM +, Kasireddy, Vivek wrote: > > In the PCIe world, I don't think a TLP can "loop back" to another > > function on the same device. > > I'm not sure

Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-30 Thread Logan Gunthorpe
On 2024-10-30 12:46, Bjorn Helgaas wrote: > On Fri, Oct 25, 2024 at 06:57:37AM +, Kasireddy, Vivek wrote: > In the PCIe world, I don't think a TLP can "loop back" to another > function on the same device. I'm not sure if the spec says anything that specifically denies this. But it seems to

Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-30 Thread Bjorn Helgaas
On Fri, Oct 25, 2024 at 06:57:37AM +, Kasireddy, Vivek wrote: > > Subject: Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for > > functions of same device > > > > On Thu, Oct 24, 2024 at 05:58:48AM +, Kasireddy, Vivek wrote: > > > > Subj

Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-25 Thread Bjorn Helgaas
On Thu, Oct 24, 2024 at 10:21:17AM -0600, Logan Gunthorpe wrote: > On 2024-10-23 23:50, Kasireddy, Vivek wrote: > >> I'd echo many of Bjorn's concerns. In addition, I think the name of the > >> pci_devs_are_p2pdma_compatible() isn't quite right. Specifically this is > >> dealing with PCI functions

RE: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-24 Thread Kasireddy, Vivek
Hi Bjorn, > Subject: Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for > functions of same device > > On Thu, Oct 24, 2024 at 05:58:48AM +, Kasireddy, Vivek wrote: > > > Subject: Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for > > >

Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-24 Thread Bjorn Helgaas
On Thu, Oct 24, 2024 at 05:58:48AM +, Kasireddy, Vivek wrote: > > Subject: Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for > > functions of same device > > > > On Sun, Oct 20, 2024 at 10:21:29PM -0700, Vivek Kasireddy wrote: > > > Functions of

Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-24 Thread Logan Gunthorpe
On 2024-10-23 23:50, Kasireddy, Vivek wrote: >> I'd echo many of Bjorn's concerns. In addition, I think the name of the >> pci_devs_are_p2pdma_compatible() isn't quite right. Specifically this is >> dealing with PCI functions within a single device that are known to >> allow P2P traffic. So I th

RE: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-23 Thread Kasireddy, Vivek
Hi Bjorn, > Subject: Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for > functions of same device > > On Sun, Oct 20, 2024 at 10:21:29PM -0700, Vivek Kasireddy wrote: > > Functions of the same PCI device (such as a PF and a VF) share the > > same bus an

RE: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-23 Thread Kasireddy, Vivek
Hi Logan, > Subject: Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for > functions of same device > > > > On 2024-10-22 09:16, Bjorn Helgaas wrote: > > On Sun, Oct 20, 2024 at 10:21:29PM -0700, Vivek Kasireddy wrote: > >> Functions of the same PC

Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-22 Thread Logan Gunthorpe
On 2024-10-22 09:16, Bjorn Helgaas wrote: > On Sun, Oct 20, 2024 at 10:21:29PM -0700, Vivek Kasireddy wrote: >> Functions of the same PCI device (such as a PF and a VF) share the >> same bus and have a common root port and typically, the PF provisions >> resources for the VF. Therefore, they can

Re: [PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-22 Thread Bjorn Helgaas
On Sun, Oct 20, 2024 at 10:21:29PM -0700, Vivek Kasireddy wrote: > Functions of the same PCI device (such as a PF and a VF) share the > same bus and have a common root port and typically, the PF provisions > resources for the VF. Therefore, they can be considered compatible > as far as P2P access i

[PATCH v2 1/5] PCI/P2PDMA: Don't enforce ACS check for functions of same device

2024-10-20 Thread Vivek Kasireddy
Functions of the same PCI device (such as a PF and a VF) share the same bus and have a common root port and typically, the PF provisions resources for the VF. Therefore, they can be considered compatible as far as P2P access is considered. Currently, although the distance (2) is correctly calculat