Re: [PATCH v2 1/3] drm/rockchip: dsi: Hold pm-runtime across bind/unbind

2021-09-27 Thread Brian Norris
On Mon, Sep 27, 2021 at 10:59:42AM -0700, Brian Norris wrote: > In commit 43c2de1002d2, we moved most HW configuration to bind(), but we > didn't move the runtime PM management. Therefore, depending on initial > boot state, runtime-PM workqueue delays, and other timing factors, we > may disable our

Re: [PATCH v2 1/3] drm/rockchip: dsi: Hold pm-runtime across bind/unbind

2021-09-27 Thread Brian Norris
On Mon, Sep 27, 2021 at 12:18 PM Tom Hebb wrote: > Reviewed-by: Thomas Hebb Thanks! > Thank you for catching this, and sorry that my original fix broke things. > There had actually been a report of this breakage from my patch, but I > missed that email until it had already been merged and then

Re: [PATCH v2 1/3] drm/rockchip: dsi: Hold pm-runtime across bind/unbind

2021-09-27 Thread Tom Hebb
Reviewed-by: Thomas Hebb Thank you for catching this, and sorry that my original fix broke things. There had actually been a report of this breakage from my patch, but I missed that email until it had already been merged and then didn't have time to follow up on it. Totally my bad. [Resending be

Re: [PATCH v2 1/3] drm/rockchip: dsi: Hold pm-runtime across bind/unbind

2021-09-27 Thread Tom Hebb
Reviewed-by: Thomas Hebb Thank you for catching this, and sorry that my original fix broke things. There had actually been a report of this breakage from my patch, but I missed that email until it had already been merged and then didn't have time to follow up on it. Totally my bad. On Mon, Sep 2

[PATCH v2 1/3] drm/rockchip: dsi: Hold pm-runtime across bind/unbind

2021-09-27 Thread Brian Norris
In commit 43c2de1002d2, we moved most HW configuration to bind(), but we didn't move the runtime PM management. Therefore, depending on initial boot state, runtime-PM workqueue delays, and other timing factors, we may disable our power domain in between the hardware configuration (bind()) and when