Re: [PATCH v2 1/3] drivers: serial: earlycon: Correct argument name

2022-08-08 Thread Rob Herring
On Sat, Aug 6, 2022 at 10:34 AM Markuss Broks wrote: > > The "node" argument is actually an offset, It's an offset to a node in the FDT. The fact that it is an offset is an internal implementation detail of the FDT format. So really, it's a handle to a node. 'node' is more descriptive to its purp

Re: [PATCH v2 1/3] drivers: serial: earlycon: Correct argument name

2022-08-07 Thread kernel test robot
Hi Markuss, I love your patch! Yet something to improve: [auto build test ERROR on tty/tty-testing] [also build test ERROR on efi/next staging/staging-testing usb/usb-testing linus/master v5.19 next-20220805] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submit

Re: [PATCH v2 1/3] drivers: serial: earlycon: Correct argument name

2022-08-06 Thread Andy Shevchenko
On Sat, Aug 6, 2022 at 6:37 PM Markuss Broks wrote: > > The "node" argument is actually an offset, and it's also > an "int", and not "unsigned long". Correct the of_setup_earlycon > function. Suggested-by: Greg KH? > Signed-off-by: Markuss Broks -- With Best Regards, Andy Shevchenko

[PATCH v2 1/3] drivers: serial: earlycon: Correct argument name

2022-08-06 Thread Markuss Broks
The "node" argument is actually an offset, and it's also an "int", and not "unsigned long". Correct the of_setup_earlycon function. Signed-off-by: Markuss Broks --- drivers/tty/serial/earlycon.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/tty/se