Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2024-12-06 Thread Mark Brown
On Fri, Dec 06, 2024 at 03:39:15PM +, Jiaxin Yu (俞家鑫) wrote: > On Mon, 2024-12-02 at 13:16 +, Mark Brown wrote: > > On Sun, Dec 01, 2024 at 05:15:45PM +, Jiaxin Yu (俞家鑫) wrote: > > > So I want to ask if I can do it by just adding > > > SOC_DAPM_PIN_SWITCH("Speakers") and SOC_DAPM_PIN_S

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2024-12-06 Thread 俞家鑫

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2024-12-02 Thread Mark Brown
On Sun, Dec 01, 2024 at 05:15:45PM +, Jiaxin Yu (俞家鑫) wrote: > So I want to ask if I can do it by just adding > SOC_DAPM_PIN_SWITCH("Speakers") and SOC_DAPM_PIN_SWITCH("HDMI")? > Correspondingly, dapm widget and route path need to be added. That is > "SND_SOC_DAPM_SPK("Speakers", NULL)/ SND_SO

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2024-12-01 Thread 俞家鑫

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-13 Thread Mark Brown
On Tue, Dec 13, 2022 at 02:23:32PM +, Jiaxin Yu (俞家鑫) wrote: > On Mon, 2022-12-05 at 12:07 +, Mark Brown wrote: > > On Mon, Dec 05, 2022 at 09:34:17AM +, Jiaxin Yu (俞家鑫) wrote: > > No, I mean that if you want to control the enable and disable of the > > output path you should implement

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-13 Thread 俞家鑫

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-05 Thread Mark Brown
On Mon, Dec 05, 2022 at 09:34:17AM +, Jiaxin Yu (俞家鑫) wrote: > 1. I have added a DAPM widget that is "SDB", when we open or close HDMI > PIN_SWITCH, the callback 'hdmi_tx_event' registered in the widget will > be triggered. Maybe you mean I shouldn't use SNDRV_PCM_TRIGGER_START > and SNDRV_PCM

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-05 Thread 俞家鑫

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-01 Thread Mark Brown
On Thu, Dec 01, 2022 at 03:06:04PM +, Jiaxin Yu (俞家鑫) wrote: > On Tue, 2022-11-29 at 17:22 +, Mark Brown wrote: > > static const struct snd_kcontrol_new > > mt8186_mt6366_rt1019_rt5682s_controls[] = { > > SOC_DAPM_PIN_SWITCH("Speakers"), > > SOC_DAPM_PIN_SWITCH("Headpho

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-01 Thread 俞家鑫

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-11-29 Thread Mark Brown
On Mon, Nov 28, 2022 at 03:07:22PM +, Jiaxin Yu (俞家鑫) wrote: > On Fri, 2022-11-25 at 12:18 +, Mark Brown wrote: > > On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote: > > I'm a little unclear why this is being implemented as a DAPM > > operation > > rather than having the driver fo

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-11-28 Thread 俞家鑫

[PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-11-26 Thread Jiaxin Yu
If the speaker and hdmi are connect to the same port of I2S, when try to switch to speaker playback, we will find that hdmi is always turned on automatically. The way of switching is through SOC_DAPM_PIN_SWITCH, however, such events can not be handled in hdmi-codec driver. So add event handler for

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-11-25 Thread Mark Brown
On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote: > + /* > + * PCM trigger callback. > + * Mandatory > + */ > + int (*trigger)(struct device *dev, int cmd); > + Making this mandatory would break all existing users, though... > + switch (event) { > + case S