Re: [PATCH v2 1/2] gpu: nova-core: add initial driver stub

2025-02-06 Thread Alexandre Courbot
Hi Danilo, On Thu Feb 6, 2025 at 11:49 PM JST, Danilo Krummrich wrote: >> > +impl Spec { >> > +fn new(bar: &Devres) -> Result { >> > +let bar = bar.try_access().ok_or(ENXIO)?; >> > +let boot0 = regs::Boot0::read(&bar); >> > + >> > +let Some(chipset) = Chipset::from_u32(

Re: [PATCH v2 1/2] gpu: nova-core: add initial driver stub

2025-02-06 Thread Danilo Krummrich
Hi Alexandre, On Thu, Feb 06, 2025 at 11:05:37PM +0900, Alexandre Courbot wrote: > > + > > +/// Enum representation of the GPU chipset. > > +#[derive(fmt::Debug)] > > I suspect you will eventually want to also derive Copy and Clone, as > well as PartialEq and Eq (so the assigned values can be use

Re: [PATCH v2 1/2] gpu: nova-core: add initial driver stub

2025-02-06 Thread Alexandre Courbot
Hi Danilo, Here are few comments - or maybe I should say nits, as they are really minor. Note that all my experience in Rust is from user-space, so feel free to ignore anything that does not make sense in the context of the kernel or is too pedantic. On Wed Feb 5, 2025 at 4:03 AM JST, Danilo Krum

[PATCH v2 1/2] gpu: nova-core: add initial driver stub

2025-02-04 Thread Danilo Krummrich
Add the initial nova-core driver stub. nova-core is intended to serve as a common base for nova-drm (the corresponding DRM driver) and the vGPU manager VFIO driver, serving as a hard- and firmware abstraction layer for GSP-based NVIDIA GPUs. The Nova project, including nova-core and nova-drm, in