Re: [PATCH v2 1/2] dt-bindings: display: Add SSD133x OLED controllers

2023-12-19 Thread Javier Martinez Canillas
Krzysztof Kozlowski writes: Hello Krzysztof, > On 19/12/2023 12:20, Javier Martinez Canillas wrote: [...] +allOf: + - $ref: solomon,ssd-common.yaml# + [...] >>> >>> + width: >>> +default: 96 >>> + >>> + height: >>> +default: 64 > > Which also looks wrong on its ow

Re: [PATCH v2 1/2] dt-bindings: display: Add SSD133x OLED controllers

2023-12-19 Thread Krzysztof Kozlowski
On 19/12/2023 12:20, Javier Martinez Canillas wrote: > Conor Dooley writes: > > Hello Conor, > >> On Mon, Dec 18, 2023 at 02:20:35PM +0100, Javier Martinez Canillas wrote: > > [...] > >>> +allOf: >>> + - $ref: solomon,ssd-common.yaml# >>> + >>> + - properties: >>> + width: >>> +

Re: [PATCH v2 1/2] dt-bindings: display: Add SSD133x OLED controllers

2023-12-19 Thread Javier Martinez Canillas
Conor Dooley writes: Hello Conor, > On Mon, Dec 18, 2023 at 02:20:35PM +0100, Javier Martinez Canillas wrote: [...] >> +allOf: >> + - $ref: solomon,ssd-common.yaml# >> + >> + - properties: >> + width: >> +default: 96 >> + height: >> +default: 64 > > diff --git a/Doc

Re: [PATCH v2 1/2] dt-bindings: display: Add SSD133x OLED controllers

2023-12-18 Thread Conor Dooley
On Mon, Dec 18, 2023 at 02:20:35PM +0100, Javier Martinez Canillas wrote: > Add a Device Tree binding schema for the OLED panels based on the > Solomon SSD133x family of controllers. > > Signed-off-by: Javier Martinez Canillas > --- > > Changes in v2: > - Unconditionally set the width and height

[PATCH v2 1/2] dt-bindings: display: Add SSD133x OLED controllers

2023-12-18 Thread Javier Martinez Canillas
Add a Device Tree binding schema for the OLED panels based on the Solomon SSD133x family of controllers. Signed-off-by: Javier Martinez Canillas --- Changes in v2: - Unconditionally set the width and height constraints (Conor Dooley). - Fix indentation in the DTS examples (Krzysztof Kozlowski).

Re: [PATCH v2 1/2] dt-bindings: display: Add SSD133x OLED controllers

2023-12-18 Thread Javier Martinez Canillas
Conor Dooley writes: Hello Conor, Thanks a lot for your feedback. > On Mon, Dec 18, 2023 at 02:20:35PM +0100, Javier Martinez Canillas wrote: [...] >> + >> + - properties: >> + width: >> +default: 96 >> + height: >> +default: 64 > > diff --git a/Documentation/device