Re: [PATCH v2 1/2] drm/mipi-dsi: add more multi functions for better error handling

2024-08-01 Thread Tejas Vipin
On 8/1/24 4:39 PM, Jani Nikula wrote: > On Tue, 30 Jul 2024, Tejas Vipin wrote: >> Add more functions that can benefit from being multi style and mark >> older variants as deprecated to eventually convert all mipi_dsi functions >> to multi style. > > What? > > Why would a lot of regular DSI c

Re: [PATCH v2 1/2] drm/mipi-dsi: add more multi functions for better error handling

2024-08-01 Thread Jani Nikula
On Tue, 30 Jul 2024, Tejas Vipin wrote: > Add more functions that can benefit from being multi style and mark > older variants as deprecated to eventually convert all mipi_dsi functions > to multi style. What? Why would a lot of regular DSI commands that are not exclusively used for one time set

Re: [PATCH v2 1/2] drm/mipi-dsi: add more multi functions for better error handling

2024-07-31 Thread Tejas Vipin
On 8/1/24 2:59 AM, Doug Anderson wrote: > Hi, > > On Mon, Jul 29, 2024 at 11:07 PM Tejas Vipin wrote: >> +/** >> + * mipi_dsi_dcs_get_display_brightness_multi() - gets the current >> brightness value >> + *of the display >> + * @ctx: Context for multiple DSI transactions >> + * @brightnes

Re: [PATCH v2 1/2] drm/mipi-dsi: add more multi functions for better error handling

2024-07-31 Thread Doug Anderson
Hi, On Mon, Jul 29, 2024 at 11:07 PM Tejas Vipin wrote: > +/** > + * mipi_dsi_dcs_get_display_brightness_multi() - gets the current brightness > value > + *of the display > + * @ctx: Context for multiple DSI transactions > + * @brightness: brightness value > + * > + * Like mipi_dsi_dcs_get_d

Re: [PATCH v2 1/2] drm/mipi-dsi: add more multi functions for better error handling

2024-07-29 Thread Maxime Ripard
On Tue, Jul 30, 2024 at 11:36:58AM GMT, Tejas Vipin wrote: > Add more functions that can benefit from being multi style and mark > older variants as deprecated to eventually convert all mipi_dsi functions > to multi style. > > Signed-off-by: Tejas Vipin Acked-by: Maxime Ripard We should also a

[PATCH v2 1/2] drm/mipi-dsi: add more multi functions for better error handling

2024-07-29 Thread Tejas Vipin
Add more functions that can benefit from being multi style and mark older variants as deprecated to eventually convert all mipi_dsi functions to multi style. Signed-off-by: Tejas Vipin --- drivers/gpu/drm/drm_mipi_dsi.c | 226 + include/drm/drm_mipi_dsi.h | 1