Re: [PATCH v2 1/2] drm/cmdline-parser: Merge negative tests

2022-09-01 Thread Maíra Canal
Hi Michał Applied both patches to drm-misc-next. Best Regards, - Maíra Canal On 8/17/22 18:12, Michał Winiarski wrote: > Negative tests can be expressed as a single parameterized test case, > which highlights that we're following the same test logic (passing > invalid cmdline and expecting drm_m

Re: [PATCH v2 1/2] drm/cmdline-parser: Merge negative tests

2022-08-19 Thread Maíra Canal
On 8/18/22 13:19, Michał Winiarski wrote: > On Thu, Aug 18, 2022 at 11:15:39AM -0300, Maíra Canal wrote: >> >> >> On 8/17/22 18:12, Michał Winiarski wrote: >>> Negative tests can be expressed as a single parameterized test case, >>> which highlights that we're following the same test logic (pass

Re: [PATCH v2 1/2] drm/cmdline-parser: Merge negative tests

2022-08-18 Thread Michał Winiarski
On Thu, Aug 18, 2022 at 11:15:39AM -0300, Maíra Canal wrote: > > > On 8/17/22 18:12, Michał Winiarski wrote: > > Negative tests can be expressed as a single parameterized test case, > > which highlights that we're following the same test logic (passing > > invalid cmdline and expecting drm_mode_p

Re: [PATCH v2 1/2] drm/cmdline-parser: Merge negative tests

2022-08-18 Thread Maíra Canal
On 8/17/22 18:12, Michał Winiarski wrote: Negative tests can be expressed as a single parameterized test case, which highlights that we're following the same test logic (passing invalid cmdline and expecting drm_mode_parse_command_line_for_connector to fail), which improves readability. In

[PATCH v2 1/2] drm/cmdline-parser: Merge negative tests

2022-08-17 Thread Michał Winiarski
Negative tests can be expressed as a single parameterized test case, which highlights that we're following the same test logic (passing invalid cmdline and expecting drm_mode_parse_command_line_for_connector to fail), which improves readability. v2: s/negative/invalid to be consistent with other t