Re: [PATCH v2 1/2] drm/bridge: Add Cadence DSI driver

2017-06-13 Thread Archit Taneja
On 06/06/2017 03:50 PM, Boris Brezillon wrote: Hi Archit, On Sun, 4 Jun 2017 00:20:06 +0530 Archit Taneja wrote: + +#define DPHY_CFG0 0x1b0 +#define DPHY_C_RSTBBIT(20) +#define DPHY_D_RSTB(x) ((x) << 16) +#define DPHY_TIF_FORCE_WRITE

Re: [PATCH v2 1/2] drm/bridge: Add Cadence DSI driver

2017-06-06 Thread Boris Brezillon
On Tue, 6 Jun 2017 16:30:15 +0300 Tomi Valkeinen wrote: > On 02/06/17 15:04, Boris Brezillon wrote: > > > +enum cdns_dsi_output_type { > > + CDNS_DSI_PANEL = 0, > > + CDNS_DSI_BRIDGE = 1, > > +}; > > Just my opinion, but I think you should only define values for enums > when those values

Re: [PATCH v2 1/2] drm/bridge: Add Cadence DSI driver

2017-06-06 Thread Tomi Valkeinen
On 02/06/17 15:04, Boris Brezillon wrote: > +enum cdns_dsi_output_type { > + CDNS_DSI_PANEL = 0, > + CDNS_DSI_BRIDGE = 1, > +}; Just my opinion, but I think you should only define values for enums when those values actually mean something and are needed. In this case, it doesn't matter wh

Re: [PATCH v2 1/2] drm/bridge: Add Cadence DSI driver

2017-06-06 Thread Boris Brezillon
Hi Archit, On Sun, 4 Jun 2017 00:20:06 +0530 Archit Taneja wrote: > > + > > +#define DPHY_CFG0 0x1b0 > > +#define DPHY_C_RSTBBIT(20) > > +#define DPHY_D_RSTB(x) ((x) << 16) > > +#define DPHY_TIF_FORCE_WRITE BIT(12) > > +

Re: [PATCH v2 1/2] drm/bridge: Add Cadence DSI driver

2017-06-03 Thread Archit Taneja
On 6/2/2017 5:34 PM, Boris Brezillon wrote: Add a driver for Cadence DPI -> DSI bridge. Signed-off-by: Boris Brezillon --- Changes in v2: - rebase on v4.12-rc1 and adapt to driver to the drm_bridge API changes - return the correct error when devm_clk_get(sysclk) fails - add missing depends on

[PATCH v2 1/2] drm/bridge: Add Cadence DSI driver

2017-06-02 Thread Boris Brezillon
Add a driver for Cadence DPI -> DSI bridge. Signed-off-by: Boris Brezillon --- Changes in v2: - rebase on v4.12-rc1 and adapt to driver to the drm_bridge API changes - return the correct error when devm_clk_get(sysclk) fails - add missing depends on OF and select DRM_PANEL in the Kconfig entry --